Lib Multipart

Lib Multipart

46.7k Downloads

Mixin incompatibility with MoreCulling

Juuxel opened this issue ยท 1 comments

commented

See Juuxel/VanillaParts#29 for the crash log. The issue is basically that MoreCulling @Overwrites Block.shouldDrawSide while LMP tries to inject into it:

@Inject(
method = "Lnet/minecraft/block/Block;shouldDrawSide(Lnet/minecraft/block/BlockState;Lnet/minecraft/world/BlockView;Lnet/minecraft/util/math/BlockPos;"
+ "Lnet/minecraft/util/math/Direction;Lnet/minecraft/util/math/BlockPos;)Z",
cancellable = true,
at = @At(value = "INVOKE", target = "Lnet/minecraft/block/BlockState;isOpaque()Z")
)
private static void shouldDrawSide(

commented

Currently, this will no longer crash, although LibMultiPart will not cull multiparts correctly. Once the 1.19 branch is ready, I can add MoreCulling compatibility to it