Lib Block Attributes

Lib Block Attributes

853k Downloads

Dank Storage's larger inventories don't work properly when LBA is installed

AlexIIL opened this issue ยท 4 comments

commented

(Tfarcenim/DankStorageFabric#7)

Dank Storage mixins to the hopper to get around the stack limit, however LBA gets there first and redirects to it's own insertion method, which has slightly different behaviour when calculating the maximum count.
Vanilla has an ItemStack-less getMaxCountPerStack(), and then calculates the real maximum by doing maths with it and ItemStack.getMaxCount(), but LBA does that all in FixedItemInvView.getMaxAmount(int slot, ItemStack stack). This results in LBA's default insertion method (FixedItemInv.insertStack) basing the maximum count on the max stack size.

Potential fixes:

  • Change LBA's hopper hooks to treat dank storage as a vanilla inventory, thus ignoring it for hoppers. This won't affect LBA-based pipes trying to insert into dank storage
  • (I assume Tfarcenim probably won't want this) Change Dank Storage to provide an LBA ItemInsertable or FixedItemInv which ignores ItemStack.getMaxCount(). This would fix every LBA-based mod trying to insert into it.
commented

(Not released quite yet)

commented

Fixed by adding compat code in LBA for Dank Storage.

commented

However I've pushed 0.8.5-pre.3 for testing.

commented

Fixed in LBA 0.8.5