Lightman's Currency

Lightman's Currency

331k Downloads

BUG: Persistant trader Ignores Trade Rules

ZEROX7 opened this issue · 7 comments

commented

Minecraft Version

1.19.2

Forge Version

43.2.2

Lightman's Currency Version

2.0.1.0

Environment Type

Dedicated Server (Bug/crash happened while connected to a server or while the dedicated server was booting)

Other relevant Mods

No response

Describe the bug

Persistant trader has 14 trades each with following rules 1. item free and then 24h buy limit
but wehn i get my first batch i can still get more items for free it seems the player tracking is bugged there

To Reproduce

persistant trader with 1 trade wit hthe following rules 1.free and a player trade limit wich forgets it 24h later

Screenshots/Logs/Crash Reports

image
image
image

commented

Update it seems its just a display issue if i click on a trade i dont get any items
but if i reset the daily limit i can buy one again for the specific cost i settup

commented

There must be some sort of server -> client sync issue with the Trade Rules then. I'll look into it and make sure it gets fixed before the next update.

Edit: Found the issue. Had to do with a flag I added to keep traders from sending update packets before they're fully loaded not being properly flagged for traders loaded from persistent data (and thus never sending update packets to the connected clients). Will be fixed in the next update.

commented

Fixed in v2.0.1.2. I'm not sure when I plan to back-port LC back to 1.19.2, but unless any major bugs come to light, this will likely be the version I port.

commented

@ZEROX7можно связаться через дискорд на счёт моды Валюта Lightmans и заинтересованные трейдеры. Просто не как не получается создать постоянный трейдер. Пожалуйста, напиши мне как с тобой лучше связаться и обговорить.

извините, не говорите на этих языках

@ZEROX7 How do I contact you. I would like to discuss persistent traders. I can't create them. I would like to ask how to do this correctly. Can I contact you or any other social network via discord?

commented

Создайте пожалуйста видео обзор, как создавать постоянный трейдер. У меня ни как не получается.
(English Translation: Create a video review please, how to create a permanent trader. It doesn't work for me.)

First off, this comment has nothing to do with this issue (the issue being that the trade rules didn't get synced properly on persistent traders), so why you're posting this here I have no clue.

Second, I already have a wiki page detailing exactly how this is done (both in-game and by manually editing the file). If you need additional help past that join my discord server (link is at the bottom of the mod description on curseforge), and ask for help there, as Github is to be used for reporting bugs/issues, or making a feature request, not for asking for help on how to use a feature.

commented

@ZEROX7 можно с тобой связаться через дискорд на счёт мода Lightmans currency и постоянных трейдеров. Просто не как не получается создать постоянный трейдер. Пожалуйста напиши мне как с тобой лучше связаться и обговорить.

sry dont speak that languages

commented

Fixed in v2.0.1.2. I'm not sure when I plan to back-port LC back to 1.19.2, but unless any major bugs come to light, this will likely be the version I port.

LC v2.1.0.0 has now been back-ported to 1.19.2, so this issue is now fixed across all relevant versions.