BUG: Creative Search Menu Does Not Work
zontreck opened this issue ยท 5 comments
Minecraft Version
1.20.1
Forge Version
47.2.18
Lightman's Currency Version
2.2.0.0g
Environment Type
Dedicated Server (Bug/crash happened while connected to a server or while the dedicated server was booting)
Other relevant Mods
No response
Describe the bug
while using the mod, the creative search tab is non-functional and appears empty.
To Reproduce
Use this mod, try to use creative search
Screenshots/Logs/Crash Reports
No crash log
Upon further testing this happens with a mod (and its dependencies), Botania. The bug goes away when either botania or lightman's currency are removed. Here is both the server and client log. If it is not a bug with lightman's i'll file this with botania.
client.log
server.log
I believe I've figured out the issue, and I'm actually amazed that this isn't an issue that always occurs...
The root of the issue seems to be in my item tooltip event handling, as it doesn't have a contingency plan for when the world isn't loaded (which it gets each items tooltips in a non-world & non-player context to generate the search trees for the creative menu according to the comments on forge's ItemTooltipEvent
). Should be an easy enough fix as I can simply have it ignore the event/not add any extra tooltips if there's no player/world being passed to the event.
Either way, I'll make sure to fix this in the next build, as v2.2.0.1 will finish stabilizing the changes I made in v2.2 (as v2.2.0.0 was slightly rushed since I wanted to get it out before Christmas so I could add the Christmas event).
Also, as an FYI, if you'd still like to be able to play in the meantime downgrading LC to v2.1.2.5 should fix the crash, although it will cause problems if the world was actually loaded and has data saved by LC 2.2.0.0 as that version has a lot of changes in how data is saved that v2.1.2.5 won't know about.