Lightman's Currency

Lightman's Currency

2M Downloads

Feature Request: Maybe feature backport to 1.19.2

dagobertdu94 opened this issue ยท 8 comments

commented

Lightman's Currency Version

1.19.2-2.2.1.3g

Is your feature request related to a problem?

I don't think so...

Describe the solution you'd like

I just wanted to ask if you have planned to bring some features that you have added to the newest Minecraft version - like the bank and prepaid cards I have read about in the wiki - to the older Minecraft versions, like 1.19.2, too?
Or if you prefer to add new content to the latest Minecraft versions only?

It would be nice if I would atleast get an answer on the questions, even if you don't plan to backport some features to older versions...

Describe alternatives you've considered

I don't know to tell the truth.
Maybe I could try to fork the 1.19.2 version of your mod and try to add it by myself.
I am not sure yet...

Additional context

And I couldn't find anything about future plans like that in the wiki...

commented

It's on his Curseforge page that due to limited time he's only updating the 1.20 and 1.21 versions, and I remember him saying that to me more than a few times in person. It's quite safe for me to say he won't do this sort of old version update himself.

I don't know how he'd feel about someone attempting to add these features and won't speak for him on that front though.

commented

Having said that, if it's for a private server/modpack I have no issues with you or someone else making your own backport of my mod for private use, or even making an "addon" that adds the features/updates I've added since for 1.19.2 as a publicly available mod on curseforge and/or modrinth.

I am not sure yet how difficult it would be to add those bank and prepaid cards with an addon.
I haven't took a look at the source code yet, how it would be possible with the existing code.
Otherwise I would need to try to copy the changes from the newer mod versions to the one for 1.19.2 in a local copy of the source code as far as possible...

[...] it is different enough in many various ways that make backporting changes to it a royal pain, even with the various utilities I've made to keep code as similar as possible between the various MC versions (i.e. making a custom screen/widget/rendering classes so that screens added by my mod can just be copy/pasted over from one version to another despite the changes made to the gui rendering system that has happened in the middle).

I know that there were many changes in between. I once tried to update the Lumpy mod (I am not sure if you know it), which is - as far as I know - only for 1.16, to 1.19.2 and failed on that because there changed too much entity related stuff to let the most code unchanged.
I know that your mod isn't working with entities but I know the problem with the changes too...

Having said that, if it's for a private server/modpack I have no issues with you or someone else making your own backport of my mod for private use, or even making an "addon" that adds the features/updates I've added since for 1.19.2 as a publicly available mod on curseforge and/or modrinth.

I would then try to make it as an addon first without modifying your mod's source code if possible...

commented

I highly doubt he'd like someone making a ton of changes for a custom unofficial version of his mod, but I could potentially see this idea work with 1.19 if someone was willing to make a side mod to add these modern features the same way LC Tech adds in some more tech-based features. That might be one way to do this even if Lightman doesn't do it himself, since his Curseforge page says...

I wouldn't want to rewrite his entire mod for just some features from newer versions.
If I couldn't make it as an addon, I would try to adapt the source code of the newer versions to keep the functionality of the features in the 1.19.2 the same as possible, even if it's just for me.

I wouldn't have chosen his mod if I would then try to "write" or "rewrite" it myself if I may call it that way.
That would be non sense in my opinion if the mod is already there and working.
I would just want to add the features from the newer versions as far as possible...

commented

And sorry if I may get on the wrong side of you.
I am not sure if I may have written my previous comments in a "not nice" kind.
My english isn't very well so I may have some problems with some sentence constructions, especially when I am writing sentences...

commented

It's quite safe for me to say he won't do this sort of old version update himself.

I don't think 1.19 is old. It may not be the latest version but it's not that old in my own opinion.
But if he doesn't have the time for it, then it may be so.
I know writing a mod takes much more time than just writing plugins for Spigot...

I don't know how he'd feel about someone attempting to add these features and won't speak for him on that front though.

In this case it would just be for my personal modpack but I don't know if anyone else could like something like that.
My problem is that I can't update to 1.20.x or 1.21.x, because we have many mods that would either break existing blocks of the corresponding mods or the mods are just non existent in newer versions.

But if he doesn't want that I even make that changes just for my local modpack, then I will have to respect it.
And so I will take the time to wait until he made his decision about this...

commented

What is "old" is always at least some matter of personal opinion. June 2022 when 1.19 landed was over two and a half years ago which is quite a bit of time for the internet, and it's quite different from 1.20 and 1.21 on a coding level. Code to make a feature work isn't always easy to reuse whenever a new feature is added due to backend changes, so a lot of the time it can be like having to do the same thing two different ways already. Having to do that a third time is a bit much, and it's not like he gets paid all that much for this work. It's not his full time job, for as much as he'd probably love it to be.

I highly doubt he'd like someone making a ton of changes for a custom unofficial version of his mod, but I could potentially see this idea work with 1.19 if someone was willing to make a side mod to add these modern features the same way LC Tech adds in some more tech-based features. That might be one way to do this even if Lightman doesn't do it himself, since his Curseforge page says...

If you're a mod developer interested in making an expansion mod for Lightman's Currency, feel free to ask me for help on either the discord linked below, or via a curseforge pm. (Discord will have a more immediate response time)

He does absolutely love talking to and helping people figure things out, this might be one solution if someone is willing to work on it.

commented

As Magik kindly pointed out, while I do agree that 1.19.2 isn't the oldest version around (heck it actually managed to get the v2.2 update/rework before I moved on to 1.21) it is different enough in many various ways that make backporting changes to it a royal pain, even with the various utilities I've made to keep code as similar as possible between the various MC versions (i.e. making a custom screen/widget/rendering classes so that screens added by my mod can just be copy/pasted over from one version to another despite the changes made to the gui rendering system that has happened in the middle). On top of that, backporting is a fairly boring and grindy experience most of the time, and I often try to limit the size of my updates simply knowing that if I make it take too long to backport I'll get bored and lose interest in my own mod which is not something I want to do.

Having said that, if it's for a private server/modpack I have no issues with you or someone else making your own backport of my mod for private use, or even making an "addon" that adds the features/updates I've added since for 1.19.2 as a publicly available mod on curseforge and/or modrinth.

commented

You said nothing to get on the "wrong side" of me, so your good on that front. That said I will be closing this issue as I have no intention of backporting newer updates to 1.19.2 or older versions.