
BUG: Villagers only buying items if changeVanillaTrades=true
JaoHundred opened this issue ยท 3 comments
Minecraft Version
1.21/1.21.1
Forge/NeoForge Version
NeoForge 21.1.94
Lightman's Currency Version
1.21-2.2.4.1a
Environment Type
Minecraft Client (Bug/crash happened in a single-player world or while the game was booting)
Other relevant Mods
No response
Describe the bug
When changeVanillaTrades=true
Villagers and wandering traders do not show the full list of the possible trades they can do.
Villagers only do buy operations and wandering traders only sell the default specified in custom_wandering_trader_trades.json
To Reproduce
- Change the lightmanscurrency-common.lcconfig config file in villagers to
changeVanillaTrades=true
- Open the game and spawn villagers with any profession, the expected should be that they have buy and sell operations
- The Villagers have only buy operations
- Spawn Wandering Trader, the expected should be that he have all his normal trades
- Wandering Trader only sell 3 items from the default custom_wandering_trader_trades.json file
Screenshots/Logs/Crash Reports (FILES ONLY)
https://mclo.gs/Uz5BnlA (debug.log)
https://pastebin.com/sssZAUPK (lightmanscurrency-common.lcconfig)
It seems that I used the wrong method to obtain the item holder when replacing the ItemCost
value, which is resulting in an error when replacing an emerald in the "cost" portion of the trade, but no errors when replacing an emerald in the "result" portion, leaving only these trade offers functioning.
This will be fixed in the next update, which should be released some time this weekend if all goes well.