Feature Request: Move the value input box on the ATM's UI below where it says "balance"
vizthex123 opened this issue ยท 14 comments
Is your feature request related to a problem? Please describe.
Yes, as I posted in #59 the UI doesn't fully fit on-screen, and I just realized that you could move the text input box and fix this issue.
Describe the solution you'd like
Just move the input box below where it says "balance", that way it will fit when using auto UI size; as well as looking nicer overall.
The box might need to be slightly smaller to fit, but this would be a great addition overall imo.
Describe alternatives you've considered
None
Additional context
Screenshots demonstrating what I mean, as sort of a "proof of concept":
My edit:
I think it looks a lot better this way, and eliminates the huge amount of empty space that was in the center.
Of course, I'm no UI designer, so it can re-aligned - but I do think the box being in the middle is way more readable overall.
The same thing could be done on the transfer UI too, the player name box could be moved up a bit, and the amount box could go below it.
also, it'd be nice if you could fix the wallet UIs in the same way it'd be nice. Maybe remove the big empty space between the text box and buttons?
I've said this a dozen times now, but I still don't think you realize this. The Coin Value Input is sized vertically to match the largest possible size it can be, (so that we don't have things overlapping when using the "standard" input method/config option). These "remove the empty space", and "it'll fit here" comments do not apply to the standard coin value input method, and thus the changes you suggest while giving screenshots of the far simpler/smaller mode cannot be applied unless there's a significant amount of empty space (which there isn't, otherwise I would have simply put it into said empty space in the first place. I may not be the best at UI design, but I'm not an idiot...)
I do plan on re-working the wallet's bank account interaction UI (probably by giving the wallet menu multiple tabs similar to how the Trader Storage menu works), but that will likely be a future update. Also, this feature request is getting a fair amount off-track, and tickets really aren't the best place to make such small tweak requests. I'd recommend joining the discord (link is at the bottom of the mods curseforge page) if you'd like to have a more proper discussion of minor tweaks that can be made.
The problem with this is that it wouldn't fit with the full-sized "default" coin value input method (believe me, I tried when I re-worked it to have a fixed width regardless of how many coins are registered). That said, I will probably go ahead and re-size the entire ATM UI so that it will have enough vertical space to fit everything, and making the entire menu taller will make it properly centered vertically such that it should all fix in a 256 pixel tall area, and thus fit the auto GUI scale. I had a couple ATM UI reworks planned, so I'll probably work it in then.
The problem with this is that it wouldn't fit with the full-sized "default" coin value input method (believe me, I tried when I re-worked it to have a fixed width regardless of how many coins are registered). That said, I will probably go ahead and re-size the entire ATM UI so that it will have enough vertical space to fit everything, and making the entire menu taller will make it properly centered vertically such that it should all fix in a 256 pixel tall area, and thus fit the auto GUI scale. I had a couple ATM UI reworks planned, so I'll probably work it in then.
yeah, that'd be noice. I would love to have this centered bar design (I didn't resize the text box input when I made that mock-up image), but idk if it's possible.
I managed to resize it to 243 "pixels" tall, and get everything to fit.
The transfer tab now looks like this:
And the interaction tab now looks like this:
Conveniently enough, I found a few small bugs with how the transfer response messages giving inaccurate transfer amounts if the sending bank account doesn't have the requested transfer amount, so those will get fixed in the process as well, but there's a few other changes I'm going to make while I'm working on the ATM screen, so it will likely still be a few days until this change is published.
ay, nice. Thanks a ton for doing this.
I need it on the 1.18.2 version if ya could though, but yeah it looks neat.
I also found that the coin input box is covered up by the item selection one inside of shop blocks, bit of an annoying bug. Applies to purchases & sales.
That's odd, as the value input shouldn't even be rendering if the item edit widget is visible, and vice-versa. There's probably an issue with it not making it's "child" widgets match it's visibility when in value mode (as opposed to the default mode which hides it just fine). I'll make sure it's fixed before the next update.
Edit: Checked the code, and that was indeed it, it wasn't matching the valueInput text box;s visibility with it's own visibility.