BUG: lightman's trade not "fully" replaced with modded trades.
GeminiMarshdevil opened this issue · 4 comments
Minecraft Version (REQUIRED): 1.18.2
Forge Version (REQUIRED): 40.1.60
Lightman's Currency Version (REQUIRED): 1.1.6.5
Other Relevant Mods & Version (LC Tech, etc.): N/A
Connection Type (Single-player, server/client, LAN world): singleplayer, also multipleplayer
Describe the bug
Lightman's villager trade replacements is not a complete replacement for modded trades. specifically Farmer's Delight trades still use emeralds
To Reproduce
Steps to reproduce the behavior:
- install farmer's delight & lightman's currency, optionally trade-cycle for easier testing, into an instance of minecraft
- launch the newly created instance
- find a villager with the farming profession
- cycle through trades till a farmer's delight trade option appears. it will be in emeralds, not coins.
Expected behavior
the farmer's delight trades, and all other modded trades, to use emerald coinage from lightman's currency ❤️
Screenshots/Logs/Crash Reports
apparently the bee keeper profession is also affected
byg is also affected
if needed, i can export the modpack i am working on and provide the download for faster testing
Did you also enable the "changeModdedTrades" config option in addition to the "changeVanillaTrades" config?
Edit: That said even if you didn't, it goes by trader not by trade, so the farmer would still be changed properly... it's possible I forgot to set the priority to lowest in the 1.18 version (which would make my version of the event run after it's been called for everyone else), so it's modifying them before the other mods add their own trades. I'll double-check the code for that real quick.
Edit 2: Yep, I forgot to change the event priority on 1.18. Should be an easy fix, and I'm gonna make sure to test it on some modded traders (Immersive Engineering to be precise as it's what I have on hand) before I post it.
