Marium's Soulslike Weaponry

Marium's Soulslike Weaponry

10M Downloads

[BUG] Parry doesn't work with shields added by other mods

PinkLasagna03 opened this issue ยท 2 comments

commented

Minecraft: 1.20.1
forge: 47.3.0
Soulslike-Weaponry: 1.1.5

When trying to parry using the keybind with other shields from other mods, the parry won't be activated. Though, it is recognized by your mod as a shield that can parry.

latest.log

commented

This is because they haven't added their items to the shield tag in c, or that they add it to a forge tag instead of common tag (some devs do either instead of both). You can manually make a datapack to fix this by adding their shield ids to the c:shields tag, but I will implement a check to see if the item is of a shield type too to avoid this in the future.

commented

This is because they haven't added their items to the shield tag in c, or that they add it to a forge tag instead of common tag (some devs do either instead of both). You can manually make a datapack to fix this by adding their shield ids to the c:shields tag, but I will implement a check to see if the item is of a shield type too to avoid this in the future.

You are right. Even though the other shields do show the tooltip that you can parry, the parry-function doesnt work. Simply adding the tag to them works! Thank you!