Marium's Soulslike Weaponry

Marium's Soulslike Weaponry

10M Downloads

[BUG] Cannot collect souls on soul-harvesting based weapons

CryoWyvern opened this issue ยท 8 comments

commented

Minecraft: 1.20.1
Fabric: 1.20.1
Soulslike-Weaponry: 1.2.1

Describe the bug
The weapons: Darkin-Scythe, Frostmourne, Soul-Reaper, and Forlorn-Scythe cannot harvest the souls needed to properly use the weapon. I have tried this mod in another modpack, and it works the way it should.

Expected behavior
The weapon to gather Souls to either summon or transform said weapon.

Screenshots and videos
here i have a video showcasing that all 4 weapons do not gather souls,
https://drive.google.com/file/d/1xZmFLo30TZ5cyWk-N94oAyZvvlGHVyCk/view?usp=sharing

Other mods or relevant info
I can't think of what mods would conflict with this issue, but here's the link to the modpack.
https://drive.google.com/file/d/1ipnMibB9gfHQb4jgON1agCCE77fQ8IML/view?usp=sharing

commented

Wait what, it doesn't have a tag, like at all? Does the item stack take damage when using it outside of creative? Because when doing the command you did (/data get entity @p SelectedItem) it should at least show that the item has 0 or more damage on the stack.

Well since it doesn't have an nbt, you can always do the give command to give you the right weapon with the right nbt data like so: /give @p soulsweapons:frostmourne{Damage:0,kills:0} 1, now the command that checks the nbt should print out that the weapon has both Damage:0 and kills:0.

commented

I really think another mod might cause this, really odd behavior, especially when it works in isolation and in other packs. I would take a look at the config, maybe delete it and restart so another generates? I don't think it is the cause so it might not help. Maybe reinstall the modpack?

You could also take a look at the items nbt data and see if it stores the value "kills", if not maybe apply it yourself? I would also look into possible mods that could break it.

commented

I really think another mod might cause this, really odd behavior, especially when it works in isolation and in other packs. I would take a look at the config, maybe delete it and restart so another generates? I don't think it is the cause so it might not help. Maybe reinstall the modpack?

You could also take a look at the items nbt data and see if it stores the value "kills", if not maybe apply it yourself? I would also look into possible mods that could break it.

i tried deleting the config but no luck, same with a mod that Might have messed with it, but still no luck. and ive already reinstalled the modpack twice cuz i'm still playing around with what mods i want. When i try the command to get the items NBT (/Data get entity @s Selecteditem) it says "Found no elements matching Selecteditem" i may be doing the command wrong but idk.

i appreciate the help ^^

Edit: the weapon has no NBT tags... so how would i add a kill tracker?

commented

Wait what, it doesn't have a tag, like at all? Does the item stack take damage when using it outside of creative? Because when doing the command you did (/data get entity @p SelectedItem) it should at least show that the item has 0 or more damage on the stack.

Well since it doesn't have an nbt, you can always do the give command to give you the right weapon with the right nbt data like so: /give @p soulsweapons:frostmourne{Damage:0,kills:0} 1, now the command that checks the nbt should print out that the weapon has both Damage:0 and kills:0.

I can try that. I have a mod called "Enchancement" By MoriyaShiine which overhauls the enchantment system and removes weapon durability completely. So no it does not take damage at all, would that be the source of the problem?

commented

It could be since the nbt never gets initialized which means other data never gets stored. All I had for those weapons was a check that if the weapons has nbt, apply my own data, but since it doesn't seem to have it nothing happens. I can try to apply a new nbt if it doesn't exist already for those weapons next update. In the meantime, I would see if removing that mod solves the problem, or just use that command.

commented

ok, it was the no-durability that was affecting it. i turned off the mod and all of them worked as they should. Thx for all of the help. ^^
although i couldn't get the command to work at all, so i'm back to normal durability. :/

commented

No problem, still weird that the command didn't work but oh well.