
[FEATURE] Liquid form of chungus potion for create mod compatability
Closed this issue ยท 4 comments
Is your feature request related to a problem? Please describe.
When putting the chungus potion into any create drain or fluid tank it becomes the uncraftable potion
Describe the solution you'd like
To add a liquid form of the potion so it can be stored in create fluid tanks
Quick question: Do normal potions work? Like do they have their own liquids automatically? Do I need to create a whole new separate liquid for the potion like how a liquid of Purified Blood exists or is there an easier way you know of?
Normal potions do work, and other potions from other mods that are minecraft:potion with the effect being in the NBT data do work. Create automatically works with potions that are Minecraft:potion by default, it has its own liquid called Create:Poiton which copies the NBT data and color of the original potion. With the chungus potion, it looks like it retains the NBT data of the potion used to make it, and it uses its own item instead of using minecraft:potion with chungus_tonic in the nbt used to apply its effects like other potions do. I think if it was using the minecraft:potion item format it would work automatically.
Though it looks like the current potion applies chungus tonic to both the player and mobs hit with it, but only applies haste to the player, and the chungus tonic effect works differently on players than it does on other entities; is that why it needs a custom item?
You could instead make a custom liquid for it and then just add a draining recipe and a filling by spout recipe for it, but I think then you might have to somehow make it so the recipes that create auto-generates don't generate (or get disabled/deleted) if that's possible? I'm not sure if that would be easier than trying to make the chungus potion use the minecraft:potion format instead, or if that wouldn't work with the way the potion works differently between players and other entities.
I've figured out a solution so that the potions at least can be transferred in and out of the fluid tanks with the Spout turning them back into the correct potion items, hopefully it works for the rest of the mod as well.