Mekanism Additions

Mekanism Additions

Mods
21M Downloads

Unable to turn off Jetpack Mode-Switching Sound

tzhouhc opened this issue ยท 0 comments

commented

Please use the search functionality before reporting an issue. Also take a look at the closed issues!

Issue description:

Unable to disable the HYDRAULIC sound played when switching jetpack/scube modes. Not sure if intentional.

Steps to reproduce:

  1. Equip jetpack.
  2. Press button to switch mode.
  3. Go into mod config, turn off both player sound, machine sound, and turn the global volume to 0.
  4. Press button to switch mode.

Version (make sure you are on the latest version before reporting):

Forge: 14.23.4.2749
Mekanism: 1.12.2-9.4.13.349
Other relevant version:

The code (src/main/java/mekanism/client/MekanismKeyHandler.java, L153) seems to indicate that is indeed intended behavior, and I've not read the code base enough to be sure if the SoundHandler is capable of controller volume globally. If that is indeed the case I can close the issue right away. Still, it would be really nice to have these sounds also under global configuration.

Also, as a personal pet peeve that is completely unrelated to the functionality of the mod (which is excellent), the HYDRAULIC sound is quite obnoxious, and even more so if I do turn all the other machine sounds down. CLICK seem to be a better choice to me -- the player is not carrying a hydraulics machine, the mode switch should just be a click on a personal device, and it's a lot quieter and shorter, making it a better fit for such notifications. But that, again, is your own artistic license and not for me to judge :)

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

[gist/pastebin/etc link here]