Personal Chest Dupe Bug
focamacho opened this issue · 7 comments
Issue description:
You can duplicate items using two personal chests.
Steps to reproduce:
1. Put 2 personal chests in the hotbar.
2. Open the first, put some items inside, and close.
3. Now u need to be fast(or have some lag). Open & drop the personal chest, and instantly change your hand to the other personal chest in the hotbar.
4. It's all. See the video for more info.
Video: https://www.youtube.com/watch?v=qlaD_9TIa08
Version (make sure you are on the latest version before reporting):
Forge: 14.23.5.2836
Mekanism: 9.7.9.380
@focamacho Can you please confirm which version of Mekanism you tested that with?
Server, because it's easier to do with some lag. You can reproduce this in singleplayer too, but it's a lot harder.
Out of curiosity is this on a server or in single player? (Mainly asking so that I can try to reproduce it in the same environment type when it potentially may not happen in the other one)
Haven't tried to replicate this yet or make a fix, but I believe what will fix it is instead of us passing the hand that is opening the chest between the server and client, if we also pass the slot ID that would fix it being able to have any doubt about what chest is really being opened. (More just putting this here as a reminder for when I get a chance to look at it more).
Also adding this to the 9.8.0 milestone as even if I don't end up replicating it (or even trying to replicate it), I probably will make the change I mentioned above which should fix it.
Version 9.8.0 was just released and should sync to the twitch client within the next couple hours. I rewrote how the GUI gets opened for the Personal chest so this should be fixed as of this release, but if it isn't feel free to reopen/comment here and I can look into it more.
