Atomic Disassembler extended vein mining
Discomanco opened this issue ยท 8 comments
Issue description:
When mining something that there's a lot of, like stone, in Extended Vein Mining, it will create odd shapes, instead of something more.. predictable. It has a tendency of preferring to mine north, rather than around the player, or the players facing direction. It mines just below 2 stacks before stopping.
A bit kin to the problem there was the Fluidic Plenisher (#4490) a long time ago
Examples of mining: https://gyazo.com/7af0e27f936a5406c9c29ed279ef34dd
Steps to reproduce:
- Be in Survival
- Put Atomic Disassembler into Extended Vein Mining
- Start mining stone deep under ground (or somewhere else with a lot of stone)
Version (make sure you are on the latest version before reporting):
Forge: 30.0.36
Mekanism: 9.9.1
Other relevant version:
That is an entirely different issue which you can open an issue up for if you want. But I don't believe I ever got around to porting the atomic disassembler to use tags instead of attempting to use the ore dict (which no longer exists)
@pupnewfster Made this instead :) #5852
Thank you for this PR, however I am going to close it as I have been working on this some already today and the proposed solution in the linked PR is not the correct way to handle tags, as it is more of a patch than an actual fix. It should be checking block tags (and in fact the whole pick block thing) no longer is needed, as can be seen here: 8887e89
I still have more things I plan on working on for the atomic disassembler before releasing 9.9.9, such as fixing this issue for the extended vein mining shape. I also want to fix and improve upon the various right click interactions to use the proper lookup maps and also support log stripping.
Closing this as it is fixed in 9.9.9, which is now released and on curseforge.
