Mekanism Generators

Mekanism Generators

97M Downloads

Raised mod incompatibility with MekaSuit HUD

JohnGoten opened this issue ยท 6 comments

commented

Issue description

Originally discovered in a personal instance (modpack development) of mine, I noticed after having configured the Raised mod to have a more lifted, bedrock-esque, hotbar visual, equipping a MekaSuit would have its HUD moved up by the equal amount as it was cut off at the top already, normally sitting comfortably within what's visible on screen
I was able to recreate this behavior within an isolated instance only using Mekanism and Raised, not even Sodium (+Iris) present. I also created an issue yurisuika/Raised#100 and was shortly informed on their discord of them seemingly only hooking into the existing GUI layers present. Of course given the clearly unintended behavior, I can only assume the MekaSuit HUD is tied to that of the hotbar which should instead be disconnected and resolve this issue (fingers crossed).
2024-12-07_15 13 32

Steps to reproduce

  1. Equip a full set of MekaSuit armor
  2. Access the Raised config via "`"
  3. Move the hotbar (top left has options for chat etc. which are unaffected) on the Y axis using the top right slider
  4. Watch as the HUD moves off-screen

Minecraft version

1.21.1 (Latest)

NeoForge version

21.1.84

Mekanism version

10.7.7 (Latest)

Other relevant versions

Raised 4.0.1 (Latest 1.21.1 as of now) https://modrinth.com/mod/raised/version/NeoForge-1.21.1-4.0.1

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

https://mclo.gs/IjUkWxk

commented

Thanks to yurisuika's help, never previously dealt with IntelliJ as your average consumer, I did manage to change the ClientRegistration.java line 318
image

event.registerAbove(VanillaGuiLayers.HOTBAR, Mekanism.rl("hud"), MekanismHUD.INSTANCE);

into

event.registerAbove(VanillaGuiLayers.CROSSHAIR, Mekanism.rl("hud"), MekanismHUD.INSTANCE);

as this seemed to be the most reasonable option available, although I tried

event.registerAboveAll(Mekanism.rl("hud"), MekanismHUD.INSTANCE);

covering up chat and the F3 menu, probably bad idea, same for BelowAll as yurisuika hinted at me regarding just the vanilla frozen or portal overlay whilst attaching it to the crosshair keeps it behind all those whilst unaffected by what appears to be any and all of Raised's configuration options, effectively solving the problem I was dealing with

and please tell me if there's a better way to demonstrate this, literally first time going this "deep" into the matter

EDIT: setting it below the SLEEP_OVERLAY may be the smartest choice available and a direct recommendation from yurisuika
image