Modular Routers

Modular Routers

Mods
33M Downloads

Inspection filter, differentiate 0% and no durability

tvanderka opened this issue ยท 2 comments

commented

Minecraft: 1.16.5
Forge: 36.1.2
Mod: 1.16.5-7.4.0-55

I want to filter items with ANY durability, but items with 1/1000=0% durability are matched the same way as items without durability.
This is caused by fix for #20, changing to val.orElse(-1) should work here

ModularRouters/src/main/java/me/desht/modularrouters/logic/filter/matchers/InspectionMatcher.java

Line 85 in af54775

return op.check(val.orElse(0), target);

commented

Fixed in 7.5.0

commented

Are you using an Inspection Filter with "durability >= 0%" to match any item that has any durability?

Yeah, I can see the problem (since that filter also matches items that don't have durability at all). Your fix does work for this case, but I'll need to do some more testing to ensure something else doesn't break....