An error in log document about sound data not found
hsiaogwa opened this issue · 3 comments
Dear Mr. zearoNineZero sir,
Have a nice day! I hope the update report arrives you moothly and doesn't bother you. I've found a little error when I run your master piece on Minecraft 1.18.2 platform, and I'm glad to describe it for you to contribute the mod.
It seems that a set of the sound in your mod couldn't be found in Minecraft 1.18.2 gramme including item.bullpup.fire, item.bullpup.enchanted_fire, item.bullpup.silenced_fire, item.bullpup.cock.What's important, the loss of sound files would cause a circle gramme which aim to find them (and a circle log in game), and the circle gramme caused severe lag in game. Soon then, multi MC launcher tip me that lod document have rose to 10,000 and I should check the case prevent it occupied my disk at a terrible speed.At the same time, I've observed that the error only burst during the second time when I launch the game, and it will run at the first time I launch the game as a correct way. I always click Quite the Game botton in Minecraft but not in Multi MC launcher.
I'll offer you my gaming log if you need it.Hope you have not bothered by my crappy procedural abilities.thank you for your time and I'm looking forward to hearing from you at your convenience.
Yours sincerely,
Alven E C (Tsingtao,China)
Dear Mr zearoNineZero sir,
I'm glad to say that it seems that I've debugged the error I've mentioned, and I hope you will not angry about I checked and modified your master piece. Follows are my opinion about the problem.
Aiming at avoiding the sound loader return "not found sound item.bullpup.fire", I added a piece of code after "item.bullpup_rifle.fire" and follow 4 sound file address in your assets/sounds.json,such as the following code. Then, I added a folder named "bullpup" in assets/sounds and copied all the files in assets/sounds/item/bullpup_rifle to the new folder, which in order to facilitate you to code later. I let the sound "item.bullpup.fire" and it's 4 following sound point to the sound.ogg file in new folder assets/sounds/item/bullpup, so that you can update the mod as before and needn't worry about the folder assets/sounds/item/bull_rifle.
Best wishes.
Yours sincerely,
Alven CHAN (Tsingtao , China)
The piece of code I updated in assets/nzgexpansion/sounds.json
`"item.bullpup_rifle.fire": {
"subtitle":"subtitle.cgm.fire",
"sounds": [
"nzgexpansion:item/bullpup_rifle/fire",
"nzgexpansion:item/bullpup_rifle/fire2"
]
},
"item.bullpup_rifle.silenced_fire": {
"subtitle":"subtitle.cgm.fire.silenced",
"sounds": [{"name":"cgm:item/assault_rifle/silenced_fire"}]
},
"item.bullpup_rifle.enchanted_fire": {
"subtitle":"subtitle.cgm.enchanted_fire",
"sounds": [
"nzgexpansion:item/bullpup_rifle/enchanted_fire",
"nzgexpansion:item/bullpup_rifle/enchanted_fire2"
]
},
"item.bullpup_rifle.cock": {
"subtitle":"subtitle.cgm.cock",
"sounds": [{"name":"cgm:item/assault_rifle/cock"}]
},
"item.bullpup.fire": {
"subtitle":"subtitle.cgm.fire",
"sounds": [
"nzgexpansion:item/bullpup/fire",
"nzgexpansion:item/bullpup/fire2"
]
},
"item.bullpup.silenced_fire": {
"subtitle":"subtitle.cgm.fire.silenced",
"sounds": [{"name":"cgm:item/assault/silenced_fire"}]
},
"item.bullpup.enchanted_fire": {
"subtitle":"subtitle.cgm.enchanted_fire",
"sounds": [
"nzgexpansion:item/bullpup/enchanted_fire",
"nzgexpansion:item/bullpup/enchanted_fire2"
]
},
"item.bullpup.cock": {
"subtitle":"subtitle.cgm.cock",
"sounds": [{"name":"cgm:item/assault/cock"}]
},`
Thank you for bringing this to my attention. I reviewed the code and figured out that the class "init\initSounds" was incorrectly calling for "item/bullpup" instead of "item/bullpup_rifle". I will implement a fix for this issue and push a hotfix once it's ready.