NoCubes

NoCubes

829k Downloads

Move the grass & flowers back to the ground

wdhwg001 opened this issue · 9 comments

commented

Now the grass & flowers sometimes partly float above the ground, which looks a bit weird.

I know it can be hard to fix, but perhaps it is possible to make those grass <1 block higher by "extending" them down on the ground.

commented

You want grass & flowers to be rendered starting lower than it actually is?

commented

Yes, and IMO it will look a bit better than partly floating perhaps?

commented

What could also be cool is making them stick to the normal vector of the ground, so they never float. That would be a bit tricky though, but it would look great!

commented

I can’t dynamically change how the terrain looks depending on what you’re looking at without a lot of overhead.
Sticking them to the terrain below them would create selection boxes and blocks that don’t match where it appears to be at all. There is also not always terrain directly underneath, or even anywhere near, the block.
Both solutions would require manually rendering the block, which would be incompatible with any other mod that does stuff with block rendering (it wouldn’t crash, it just wouldn’t have the other mods changes applied). The best solution to this would be to stretch the block down a bit, but this is also very hard.

commented

@Jummit But it will create empty grass/flower block, and that means more than 1 block in a block area. For me I would accept the "extend-to-the-ground" solution, although it will make small flowers and mushrooms look a bit weird.

Wait, is it possible to show a floating transparent copy of grass/flower/mushroom when pointing to the exact block of them, and also stick them to the normal vector of the ground?

commented

How about changing the grass/flower/mushroom model? I mean, maybe we can make them have a model which is 2-block in height and take 1 block under it, but let them remain their 1 block logical size. This will make their models stick through the ground surface, but still look much better than floating.

commented

I'm not sure, are there completely floating grass/flower/mushroom blocks that are not connecting with the ground on any edges? If not, how about moving the smaller model (mushroom etc.) to the closest attached edge inside the block first, and then extend them?

commented

That would kill resource pack support. I think that I could modify the model as it is loaded and extend the lower elements of it down. It might looks strange but it wouldn’t be completely incompatible.

commented

Fixed as of 30645b0. What I did was cancel vanilla's normal flower rendering and then just render the flower myself on any smooth NoCubes terrain face that had a flower above it (I rendered the flower with the y position of the face).