[FABRIC] Makes Bumblezone super dark by not respecting the ambient lighting values in the dimension type
TelepathicGrunt opened this issue ยท 3 comments
Version Information
Minecraft Version: 1.20.1
Fabric Loader Version: 0.92.2
Fabric API Version: 0.15.11
Nostalgic Tweaks Version: 2.0.0-Beta-8.4.1
Describe the Bug
Nostalgic Tweaks does not respect the ambient lighting value that modded dimensions may have. For Bumblezone, it is this value here:
You can quickly enter my dimension by doing /execute in the_bumblezone:the_bumblezone run tp ~ 90 ~
Screenshots
What the bugged look of my dimension is with Nostalgic Tweaks:
What it is supposed to look like (Nostalgic Tweaks removed):
This was definitely an oversight on my part. The Old Classic Light Rendering forces the lightmap to be full-bright, which is why turning that on made everything look like it should. I added ambient lighting into the old lighting brightness calculation. The result is not as bright as the "expected" screenshot, but the old lighting was famously very dark.
The old lighting can be made brighter by setting Disable Vanilla Brightness to disabled, which will let the brightness setting in the video settings impact the light texture map again.
Thank you for the report and screenshots, this is a very cool dimension/mod!
Turning on this value fixes the issue
However, I still consider it a bug that Nostalgic Tweaks does not respect the Dimension Type ambient lighting value for datapack/modded dimensions.