Incompatibility with Fluidlogged-Api
wed15 opened this issue ยท 3 comments
Describe the bug
When Fluidlogged-Api and Nothirium installed together water and any kind of fluids are not visible on fluid-logged blocks. Reproduceable with only both mods.
To Reproduce
- Install Fluidlogged-Api and Nothirium with dependency in same instance
- Join any world
- Waterlog any blocks and see if water is visible
Screenshots
Without Nothirium:

With Nothirium:

Versions
Nothirium: 0.1.6-beta
RenderLib: 1.1.0
Fluidlogged-Api: 1.8.1c
Forge: 14.23.5.2860
Minecraft: 1.12.2 (obviously)
Hardware
CPU: AMD Ryzen 5 3500 6-Core Processor
RAM: 16GB
GPU: Radeon RX 570 Series
VRAM: 4096MB
Log File
latest.log
debug.log
@Meldexun does implementing something similar to PluginRenderChunk inside RenderChunkTaskCompile#run fix the issue? Not gonna implement the fix from my end since it makes more sense to implement from your end (mine would require asm, yours doesn't).
@jbredwards I guess that would fix the incompatibility. But I don't use the vanilla classes like ChunkCompileTaskGenerator or CompiledChunk. Thus I would have to copy all three ASMHooks#renderChunk methods which isn't something I want to maintain.
Fixed through #41