Nothirium

Nothirium

953k Downloads

Incompatibility with Fluidlogged-Api

wed15 opened this issue ยท 3 comments

commented

Describe the bug
When Fluidlogged-Api and Nothirium installed together water and any kind of fluids are not visible on fluid-logged blocks. Reproduceable with only both mods.

To Reproduce

  1. Install Fluidlogged-Api and Nothirium with dependency in same instance
  2. Join any world
  3. Waterlog any blocks and see if water is visible

Screenshots
Without Nothirium:
2022-07-04_17 29 40
With Nothirium:
2022-07-04_17 10 43

Versions
Nothirium: 0.1.6-beta
RenderLib: 1.1.0
Fluidlogged-Api: 1.8.1c

Forge: 14.23.5.2860
Minecraft: 1.12.2 (obviously)

Hardware
CPU: AMD Ryzen 5 3500 6-Core Processor
RAM: 16GB
GPU: Radeon RX 570 Series
VRAM: 4096MB

Log File
latest.log
debug.log

commented

@Meldexun does implementing something similar to PluginRenderChunk inside RenderChunkTaskCompile#run fix the issue? Not gonna implement the fix from my end since it makes more sense to implement from your end (mine would require asm, yours doesn't).

commented

@jbredwards I guess that would fix the incompatibility. But I don't use the vanilla classes like ChunkCompileTaskGenerator or CompiledChunk. Thus I would have to copy all three ASMHooks#renderChunk methods which isn't something I want to maintain.

commented

Fixed through #41