Possible solution for #21
Sunconure11 opened this issue · 69 comments
You should probably check this out.
Doesn't Connectivity already solve this issue by bumping the maximum packet size?
Connectivity is really just a monitor, it only fixes 3 packet size (minecraft have 6), phantom blocks, improves errors and gives you information about packet usage. Connectivity does nothing else.
You wanna take this over? There is a lot of info here.
Also, would it be possible to make a version of the packet splitter mixin that is compatible with Krypton?
MinecraftForge/MinecraftForge#7485
There were two, separate ideas of the same thing, in these pulls. A packet splitter, basically. Forge has an implementation but Fabric/Quilt do not.
Doesn't Connectivity already solve this issue by bumping the maximum packet size?
I had also did quite a bit of testing to see if my issue was packet-related or mod-count related. Still working on trimming the mod count.
And it seems in some cases, it does not fully solve the issue, if this issue is packet-related.
It seems that it will cause this mod required in both client and server?
It is simply pinned, it will not be done for the time being.
Packet splitter mixin seems to be failing.
Test this version:
PacketFixer-fabric-1.1.8-1.19.2.test21.zip
Do you have any idea as to when you'd be free to do this? I know I normally shouldn't ask this, but given the nature of this solution, it would probably help quite a few people.
@Linguardium Maybe you can help with getting this on various versions of the mod?
I discovered this in 1.19.2 though, so I'd say 1.19.2 and up should receive this.
Do you have any idea as to when you'd be free to do this? I know I normally shouldn't ask this, but given the nature of this solution, it would probably help quite a few people.
The creators of Forge and Fabric said they were not going to do it because they don't think it is the most optimal way. If a case will create a separate mod.
@Sunconure11 Test this version:
PacketFixer-fabric-1.1.8-1.19.2.test20.zip
I will shortly. It looks like a mod had a bad update or something for me currently.
I'll get back with you in a little while. I also woke up a bit... too early, and I also still haven't found why I'm having an unrelated issue.
Alright, it looks like I can begin bug hunting now
Let me know if I have managed to solve the problem you had last time.
https://gist.github.com/Sunconure11/fbd57261851d30552685e64655cdfa7e
What is the problem? 5 thousand lines are difficult to read.
Packet splitter mixin seems to be failing.
If you find a possible cause, I'll test it again, but I need to lay down for a bit.
Tried to test with Very Many Players to see if I could load in fully, but I just got stuck at the loading screen for the server. Gonna see if Krypton has issues with these changes next. Will take pictures and logs of both issues. But it seems we are getting close.
https://legacy.curseforge.com/members/someaddon/projects
Some of the chunk-related mods may need a look over in regards to compat with VMP and this.
Looks like the packet splitter mixin fails with Krypton.
VMP gets stuck on loading terrain. There was one last issue, lemme recreate it.
Okay, so it seems the VMP issue occurs not because of VMP, but due to the map itself. It does not want to load in. Although VMP seemed to get me close, as I could hear the sound playing from the world.
latest.log
Server log
latest.log
Client log
I'm seeing a mixin failure in the log with this...
https://www.curseforge.com/minecraft/mc-mods/better-chunk-loading-forge-fabric
Also, regardless of my results, could you check these two mods for any possible incompat issues for the possible solution?
Connectivity is full compatible
If I find any more info, I will post it. But I do not seem to know of anything, aside from maybe some kind of issue with the chunk performance mods
@Linguardium @TonimatasDEV Maybe compare the Forge solution to the one being attempted? Maybe they solved weird issues like this.
https://apexminecrafthosting.com/pricing/?game=minecraft
Using the EX Series plan.
It shows me logged in on the log... but I am not physically in game.
TPS could be mods, yes, but I want to see what is going on a bit more. I am planning on further cleanup of this pack, but I've been unable to find someone willing to help me, or has the time to.
A modpack of 831 mods is too big, you would need a very very powerful server, how many cores and ram do you have in the server?
Looks like the packet splitter mixin fails with Krypton.
Delete Krypton
@Sunconure11 Does it let you login to the server? Is the TPS problem caused by Packet Fixer or by the number of mods?
It shows me logged in on the log... but I am not physically in game.
TPS could be mods, yes, but I want to see what is going on a bit more. I am planning on further cleanup of this pack, but I've been unable to find someone willing to help me, or has the time to.
Cleanup is a bit hard here too, given a lot of the config stuff I did, and what not.
I might have found someone to help with clean up. If, after this effort, this still happens, I'll come here. I will hold onto a build of Packet Fix created here just until then, just in case any issues pop up in singleplayer while working on this
My PC may be more powerful, but I'd rather wait until I have something like a 5950 for running any servers from my machine, so that I have more cores and threads free.
I am also using Aikar's flags on the server, to help with performance.
Looks like the server is now hitting something that is more likely related to the host themselves. I'll see what can be done there.
16.09 19:53:37 [Server] Netty Epoll Server IO #5/WARN java.lang.OutOfMemoryError: Requested array size exceeds VM limit
16.09 19:53:37 [Server] Netty Epoll Server IO #5/WARN Network error for:packet_handler
16.09 19:53:37 [Server] INFO java.lang.OutOfMemoryError: Requested array size exceeds VM limit
16.09 19:53:37 [Server] Netty Epoll Server IO #5/ERROR Twilight Forest: Exception occurred in netty pipeline
16.09 19:53:37 [Server] INFO java.lang.OutOfMemoryError: Requested array size exceeds VM limit
16.09 19:53:37 [Server] Netty Epoll Server IO #5/ERROR Exception occurred in netty pipeline
16.09 19:53:37 [Server] INFO java.lang.OutOfMemoryError: Requested array size exceeds VM limit
16.09 19:53:37 [Server] Netty Epoll Server IO #5/WARN java.lang.OutOfMemoryError: Requested array size exceeds VM limit
16.09 19:53:37 [Server] Netty Epoll Server IO #5/WARN Network error for:packet_handler
16.09 19:53:37 [Server] INFO java.lang.OutOfMemoryError: Requested array size exceeds VM limit
Server uses 16 gigs, but it is apparently running into this when it is not even using that much RAM.
I have posted it here just in case it is being a bit deceptive and that is not host related.
Server uses 16 gigs, but it is apparently running into this when it is not even using that much RAM.
Better not to fix this problem, as it causes the servers to consume all your ram. That's why it has these limits. Thank you very much for reporting this bug.
Just curious, but do alternate solutions exist that don't eat up so much memory?
I decided to do some digging, by running the server and client without Packet Fixer.
I am also using these mods, in case they may have recipe conflicts:
https://www.curseforge.com/minecraft/mc-mods/block-swap
https://www.curseforge.com/minecraft/mc-mods/almost-unified
https://www.curseforge.com/minecraft/mc-mods/recipe-essentials-forge-fabric
Or at least, are physically possible?
They may be possible, but I have not seen them exist.
@Sunconure11 I have a plan for fix this
Of note is that this mod still has some oddities with Krypton installed, and with all of these tests, I had to uninstall Krypton. I suggest adding some compat there too.
Just curious, but do alternate solutions exist that don't eat up so much memory?
Forge already has the fix for it built into forge itself. this would really only be needed for Fabric. As far as Quilt goes, i am not sure if the mod is being developed for Quilt or if quilt compatibility is assumed, but i would suggest making sure that whatever base it is being developed on is the base it is being tested on. just to make sure the quilt team isnt doing something funky (they have been known to break things with their QSL and such)
I'm mostly on Quilt because there are a few things exclusive to it that I wanted to play with.
Just curious, but do alternate solutions exist that don't eat up so much memory?
Test this version:
PacketFixer-fabric-1.1.8-1.19.2.test3246178234.zip
Also, regardless of my results, could you check these two mods for any possible incompat issues for the possible solution?
Hm, we may be close. I can enter, but the TPS seems to be very low, so stuff takes forever to load up on my end. It is possible pregeneration may be needed at this point, but I'll see how a restart of the server handles things first.
No visible errors in the log, aside from can't keep up ones. Gonna try some ideas in the mean time to clean those up.
Also, this issue first came up while testing, but just to make sure of something, but is this my GPU going bad, or something else?
I am starting on some cleanup of the pack (mod count is deceptive, it is actually 648 as of typing this, but that is due to me cleaning stuff up) up until I can get it to a point where I can enter fully and load a world,
Hm... I have a suspect mod, but I don't know for certain. However, I am calling it suspect due to it's nature.
My reason for thinking it could be suspect is due to the sheer amount of recipes it could end up adding in the right situations.
I am going to turn it off, and see what happens.
Edit 1: Okay, so this wasn't the cause. Will look into further clean up later. Though speed was much greater.
Doesn't Connectivity already solve this issue by bumping the maximum packet size?
Looks like according to @TonimatasDEV, it does not really. @embeddedt
@Sunconure11 The version I passed you does not work?
Well, I still can't load into a server fully, as it just stalls in a ghost world, best way to describe it, despite the console saying I'm in.
@Sunconure11 The version I passed you does not work?
It works, but I was referring to Embed.
While hunting for people to aid me with my pack, someone pointed out this issue to me, and given I have both mods… maybe there’s something here that can be done? terrarium-earth/Chipped#214