Paxi (Fabric)

Paxi (Fabric)

10M Downloads

Feature Request: Config option for specifying other directories from which data/resource packs can be loaded

yungnickyoung opened this issue ยท 27 comments

commented
commented

Unfortunately it will probably have to stay limited to 1.21.1+. The mod went through a rewrite when porting to 1.21 and I think it would be difficult to backport this addition

commented

Unfortunately it will probably have to stay limited to 1.21.1+. The mod went through a rewrite when porting to 1.21 and I think it would be difficult to backport this addition

Oh, I'm using 1.20.1 so that kind of sounds like a pain. I can understand that it is hard to do so but there is also thousands of people still using 1.20.1 which is the version of my modpack Elysium Days too, so if it was coming to 1.20.1 it would have been great.

Specially when Resource Pack Overrides is the only alternative and its much more complicated than Paxi while your mod is just works the best even if the file is missing, doesn't require a lot of syntaxing, and just well made.

commented

Btw, I assume this conversation mostly applies to resource packs specifically, right? i.e. wanting to automatically load any resource packs placed in the vanilla resourcepacks folder

commented

Btw, I assume this conversation mostly applies to resource packs specifically, right? i.e. wanting to automatically load any resource packs placed in the vanilla resourcepacks folder

Not automatically, still a load order file but instead of config > paxi > resourcepacks i want them to work in yourmodpackfolder > resourcepacks so that they also show up as embedded automatically in every release of the modpack.

commented

How about if the resource pack load order JSON is also capable of referencing files in the vanilla resourcepacks folder? For example, if I have a load order json entry called MyPack.zip, it would first check the config/paxi/resourcepacks folder for MyPack.zip, and if no matching zip was found, it would then check vanilla resourcepacks.

That way you wouldn't have to manage two different JSON files.

Hmmm that would be a little complicated and unclear, maybe instead of just defining 1 place let there be a config screen that lets you put a path and Paxi looks for that path if it exists, like you can even do yourmodpackfolder > random-folder > random-folder2 > resourcepack.zip

commented

How about if the resource pack load order JSON is also capable of referencing files in the vanilla resourcepacks folder? For example, if I have a load order json entry called MyPack.zip, it would first check the config/paxi/resourcepacks folder for MyPack.zip, and if no matching zip was found, it would then check vanilla resourcepacks.

That way you wouldn't have to manage two different JSON files.

commented

Eh I'm not really interested in trying to add a custom directory option atm, it's not really necessary. Just focusing on supporting the vanilla RP directory specifically for the sake of creator attribution like you've mentioned.

And I don't really see how it's complicated, I think it's pretty straightforward to simply state that Paxi looks for RPs in the paxi folder first, and then in the vanilla folder.

commented

Eh I'm not really interested in trying to add a custom directory option atm, it's not really necessary. Just focusing on supporting the vanilla RP directory specifically for the sake of creator attribution like you've mentioned.

And I don't really see how it's complicated, I think it's pretty straightforward to simply state that Paxi looks for RPs in the paxi folder first, and then in the vanilla folder.

That can be good but what if theres the same file in both directories? Or if we only want one of them instead of both

commented

It would choose the first one found (in the Paxi folder) as an override, and probably log a warning message

commented

It would choose the first one found (in the Paxi folder) as an override, and probably log a warning message

Then that's a great way to fix! Will there be a 1.20.1 port of this too? I hope not only for 1.21.4 xD

commented

@yungnickyoung That is a must have because developers packs do not show as embedded and they get 0 download, and that's the worst thing can happen. Will this be implemented any soon?

commented

global included dependencies

Wdym by global included dependencies? And by duplicate downloads I meant that if its embedded i think it also downloads it once again to the resource pack folder alongside the paxi folder, so how does that even work? Because if it didnt download it again if it was embedded but still they get downloads, that would be a massive error in monetization system, allowing people to add embedded stuff of theirs even tho if its not in the modpack and make more downloads.

commented

Any modpacks using Paxi to load packs that exist on CurseForge should be manually marking them as embedded dependencies. Is that not happening?

commented

Any modpacks using Paxi to load packs that exist on CurseForge should be manually marking them as embedded dependencies. Is that not happening?

I don't know about CurseForge, but Modrinth does not. Because Modrinth detects them from corresponding folders of theirs, and if they don't exist there all the resource pack devs get 0 download.

commented

You can manually go on putting them as embedded which if you have much resource packs like me around 30, it will be a pain for every release. But i believe that it will download them twice if you do that then, not sure.

commented

If Modrinth doesn't have support for manually adding packs then I'll have to look into adding this soon. But CF definitely does given how many modpacks Paxi is used in, and I don't think there are any issues with duplicate downloads. Also, you can mark the packs as global included dependencies and they should be automatically added to every release, so there's no need to manually edit each release.

commented

Wdym by global included dependencies?

You can add "Default Relations" to a project, which will then automatically apply to every release.

And by duplicate downloads I meant that if its embedded i think it also downloads it once again to the resource pack folder alongside the paxi folder, so how does that even work? Because if it didnt download it again if it was embedded but still they get downloads, that would be a massive error in monetization system, allowing people to add embedded stuff of theirs even tho if its not in the modpack and make more downloads.

I thought that if you simply add a project as a dependency manually, either when uploading or as a default relation, then it marks that project as a dependency without downloading anything. You can then separately add the pack to paxi's config folder via an override.

commented

I thought that if you simply add a project as a dependency manually, either when uploading or as a default relation, then it marks

Wdym by override? Like the feature that we waiting for?

commented

No, just like how modpacks can have an "overrides" folder for including things like default configs, resourcepacks, third party mods, etc.

commented

No, just like how modpacks can have an "overrides" folder for including things like default configs, resourcepacks, third party mods, etc.

But still that feature would be good so that it would be automated instead of manually adding those.

commented

Gotcha. I remember I tried a while ago and something about it was particularly challenging since Paxi modifies pack load order, but I'll try to give it another shot soon.

commented

Gotcha. I remember I tried a while ago and something about it was particularly challenging since Paxi modifies pack load order, but I'll try to give it another shot soon.

Thanks! It would be great if you drop a comment here when It's done because I don't wanna make another release of my modpack without devs getting what they deserve ๐Ÿ˜”