Prefab

Prefab

12M Downloads

Water in non-overworld dimensions

Dqu1J opened this issue · 2 comments

commented
  1. What version of Minecraft, Forge and Mod are you running?
    1. source
  2. What type of issue is this? Choose one of the following:
    1. Enhancement (Add/Change something)
  3. If this is an enhancement, please provide as much detail as possible for what you would like to see changed or added. This will reduce the amount of questions we have later and provides you with what you need.

This line:
if (!World.OVERWORLD.getValue().toString().equals(world.getRegistryKey().getValue().toString())) in src/main/java/com/wuest/prefab/structures/base/Structure.java
Will remove water everywhere except overworld. The water should still be present in the end, and modded dimensions that allow water in them.

To solve that, In Fabric, there is DimensionType.isUltrawarm() (link), which will be true if there can’t be water. It also works with modded dimensions. I’m not sure about Forge, but there should be a value for this too.

commented

We will also be adding a configuration option to determine if the End can have water through the prefabs. By default this will be turned on. Modpack developers can turn this setting off based on their needs.

commented

This will be available in the next releases for 1.16.5 and 1.17.1.