Prefab

Prefab

12M Downloads

Client Crashes when U build 2 structures at the same time. [1.12]

Fundryi opened this issue ยท 7 comments

commented

Version Infos:
Forge: Latest
Mod: Latest

Just wanted to share this.
I started a "structure" and thought what would happen if you start the second one at the same time its building the first one, aaand crash :(
Could be really "annoying" on a server if people use ur mod at the same time.

Crash: https://gist.github.com/Fundryi/fabdac4b971b17d09744fa71b178dd4a

commented

Interesting error.

What 2 structures were you generating and what dimension?

commented

Cool that it is fixed but I really don't get Developer like u xD It a bug fix why don't just release the updated?
Let the people decide if they want it or not :P

commented

Thank you for the information. I was able to to duplicate the issue and figure out what the problem is. I will wait a while until releasing this fix since I just released 1.12 yesterday ๐Ÿ˜„.

This has been an issue for a long time. I guess you are just the first person whom attempted this since this the enhancement of generating multiple structures at once was released.

It still lags the server but at least it doesn't completely freezes it.

commented

I get were you are coming from and fortunately right now I have to the time to do a release ๐Ÿ˜„. But usually why something isn't released right away is due to other factors.

For instance, I could be working on a major overhaul(I'm not) that I haven't put out here yet and don't want to release partially done code (even if it's setup to not be used). For me this is a side project, I do this for the love of programming and the wonderful sandbox which Minecraft is, but because it is a side project, I don't have a lot of time to dedicate to it. (Hence why it took like a month to get to 1.12).

I also have to consider how likely the bug is to be found and how critical of a bug it is. While it does crash the server which marks it high for a fix, the likely hood of people finding it is low. In this particular case the player has to build two buildings at the same time. Two Different players can build at the same time but when the SAME player tries to build two buildings is where the problem arises. My gut tells me that this is an edge case.

I am in the process of updating all 3 versions right now. I will close this issue once they are all approved on curse.

Thanks! ๐Ÿ‘

commented

ahh okey cool :) thanks for the info.

commented

The versions have been released and approved on curse forge.

Closing issue.

Thanks!