[Bug]: Broken hitboxes
Closed this issue · 7 comments
What happened?
Mod causes issues with normal entity hitboxes, for example
- Magma Cubes have larger hitbox no matter their size. (This can cause froglight farms to break by dying magma cubes being forced through the walls).
- Pufferfish don't change size when bloated (this breaks normal game like pufferfish doors)
Video files were too big to add (and weren't embedding)
Minecraft Version
1.20.1
Modversion
https://modrinth.com/mod/random-mob-sizes/version/1.20.1-1.3-Fabric
Modloader
Fabric
Additional context
No response
Before submitting
- I tested that the problem is caused by this mod (the bug does not happen when removing this mod)
- I checked that there are no similar posts (open or closed) related to the this problem
Would you possibly have a timeframe? We'll be updating our server in a couple weeks and will have to unfortunately remove the mod if not looked into before then.
Sorry, no timeframe
I have a general idea what might cause this, but not really sure how to fix it
Can add spiders to the list. No matter what size they have, hitbox stays the same. Yet, the line of sight's position get changed. So if a spider is very big, its line of sight is very high above the hitbox and it can suffocate easily.
Edit: In my case, the mod loader is Forge 1.19.2 43.3.2
An example of such big spider with tiny hitbox and a line of sight inside of its body:
I had a quick play around and appears to be the refreshDimensions mainly this line. I replaced with EntityDimensions dimensions = entity.getDimensions(pose); which seemed to fix the main issue but seems to break hitboxes on baby entity.
Edit:
After bit more playing, above slightly fixed by the hitboxes are still incorrect (too small). I decided to just remove the whole refreshDimensions section which seems to work fine and all hitboxes are correct. What is the purpose of this mixin?
Originally I had problems with hitboxes for slimes, when they die/split-up and get smaller.
The mixin was there to counter these issues, but that's some time ago, maybe the mixin is unnecessary by now.
Thanks for testing/debugging, will look into it as soon as I have time