Robotic Parts

Robotic Parts

1M Downloads

[1.12.2] Conflict with 'Metallurgy Reforged'. Targeting Overlay won't highlight mobs.

SonicX8000 opened this issue ยท 4 comments

commented

Refer'd Issue:
Davoleo/Metallurgy-4-Reforged#203

Minecraft: 1.12.2
Forge: 14.23.5.2838

Mods: 3
cyberware-1.12.2-0.2.11.20
jei_1.12.2-4.15.0.279
Metallurgy-4-Reforged-0.2.2


Figure I give it a post here as well...

The "Targeting Overlay" seems to not highlight mobs anymore if Metallurgy is installed. Some screenshots...


If Cyberware + Metallurgy is installed... no highlighter on the Sheep.


If Metallurgy isn't installed... the highlighter works as intended. The Sheep has an outline as well as two more mobs in the distance.

Note: The Augment Wheel is shown as the augments are 'enabled'. If they weren't... it'll have the option to 'enable' them, not 'disable'.

commented

Apparently if wearing the Mithril Set from Metallurgy which causes mobs to become highlighted & having the Targeting Overlay enabled... some weird stuff occurs.

If wearing the armor... the Targeting Overlay highlights mobs... but only if they're far away. If you get close to them... then the highlighter will disappear on them. If you disable the Targeting Overlay... the highlighter will show due to the Mithril Armor's passive but with less distance.

I wonder if these two are somewhat fighting over what to do for highlighting mobs. Just making a guess here.

commented

Just checked the code again and Cyberware only glows entities that aren't glowing already, and it'll only remove the glow from entity it did add glow to. I've found a memory leak but nothing that would explain what you've reported. Looks like Metallurgy is forcing a clear on the potion effect that it didn't apply.

commented

yeah, it's probably on our side

commented

This issue has been fixed on Metallurgy's side. If something should occur again I'll let you know.