Epic Fight Mod battle stance model rendering issues when cyberarm installed
ubergarm opened this issue ยท 2 comments
Description
Dual-wielding cyberware katanas with Epic Fight is so much fun! However, after I installed a cyber arm the animations no longer render correctly. Nothing crashes and I can still play but it doesn't look right at all when in "battle stance mode". It is fine in normal mode though.
The issue is the same after installing a ReWIRED necrotic arm.
I would love to be able to fight with cyber arms and claws installed and see the enhanced Epic Fight punching animations too!
Versions
Forge: forge-1.12.2-14.23.5.2855.jar
Robotic Parts: cyberware-1.12.2-0.2.11.29.jar
ReWIRED: ReWIRED-1.0.9b.jar
Epic Fight: EpicFightMod-1.12.2-2.2.7.jar
Related Issues
The Epic Fight Mod has an issue with guidelines on specifying model class rendering information that it seems to pickup. Given the cyber arm (and necrotic arm) look fairly close to the normal arm maybe it just needs some more complete information or texture mapping to get it to work?
EDIT: Just noticed #108 and #147 and after reading the note found the config option after grep'ing the codebase. Will report back soon!
B:"Enable changes to player model (missing skin, missing limbs, Cybernetic limbs)"=true
How to Reproduce
My modpack Rotten Economy has everything you need to recreate the issue. Go into creative, drop down a robosurgeon on top of the chamber, give yourself a new arm, then go into battle stance mode and see how it doesn't do the animations correctly.
Source code for configs on the modpack github here Rotten Economy Modpack Github
Cheers and no big deal if this isn't as easy as specifying some model data... The katanas are plenty fun enough! Thanks!!
Cyberware uses a wrapper on the player model so it can customize limbs textures and rendering. It's too much work to fix on 1.12.2. Pull requests are welcome through.
Thanks much, I'm still working on the pack dev CraftTweaker ZenScript level, but might dip my toes into Java despite swearing it off for over 20 years! haha...
Quick work-around for now is to just turn off the renderings in cyberware.cfg
with:
B:"Enable changes to player model (missing skin, missing limbs, Cybernetic limbs)"=false
Lookin' forward to playing with your great content soon!