Robotic Parts

Robotic Parts

2M Downloads

Crash when inserting item into scanner.

MrRedstoneA1 opened this issue ยท 7 comments

commented

I inserted a hudlens into the scanner without any paper in it. The game instantly crashed. Crash log below.
crash-2022-05-16_18.46.48-client.txt
IMPORTANT EDIT: Discovered that this is due to my homemade custom resource pack that makes some of the cyber items have 3D models. As a result, every item I try to scan crashes the game.

commented

what are your language setting when reproducing the issue? please try to reproduce in English?
I bet you're in zh-cn which doesn't have a valid language resource file, here: https://github.com/An-Sar/Cyberware/blob/1.12/src/main/resources/assets/cyberware/lang/zh_cn.lang#L330-L406

commented

No, the language is en-us. I have however edited the lang file in the resource pack. After removing the katana json from the item models, it no longer crashes.

commented

It sounds more likely that the edited lang file isn't respecting the contrains I've linked earlier?

commented

Might be. I'm testing again but I removed the lang folder. Now it should be using the mod's original en-us lang file.

commented

AHA, it seems to be the lang file. I removed some of the scanner sayings because I didn't need that many, maybe that plus the 3D item models caused the crash? I could give you a barebones resource pack that can replicate the crash.

commented

yup, no more crashes. Thank you very much for finding the issue, now I don't have to re-do a bunch of the items in my pack! Though I have never seen this kind of problem before, where a resource pack containing a modified lang file paired with 3D item models causes the game to crash. Very odd.

commented

it's only the lang file that was invalid, you've removed a critical line, see the comments in the link I've posted. Eitherway, it's fixed.