Robotic Parts

Robotic Parts

2M Downloads

Lag in event handler

LemADEC opened this issue ยท 2 comments

commented

As of cyberware-1.12.2-0.2.10.15 found in FTB Interactions 1.0.1, there's significant lag coming for the mod event handling, even with a single player online:
image

Details on the first sub-event:
image

From the looks of it, each upgrade has its own event that'll check for capability through flaxbeard.cyberware.api.CyberwareAPI.isCyberwareInstalled() . The latest is fairly inefficient.

Since most entities have no robotic parts, consider inverting the loop logic (get installed upgrades then loop on them, instead of looping all possible upgrades then check if they're actually installed).

commented

I confirm. Cyberware heavily reduces server TPS.
2019-06-28_18 11 55

commented

Dup of #66
Fixed in dev