Identify enchanted items
BVengo opened this issue · 3 comments
Hello @BVengo, one more thing came into my mind.
Maybe add support for enchanted items too - that the enchantment glint would be visible.
Originally posted by @mrniddala in #6 (comment)
Yep, just show the first or last item enchantment if enchanted, very helpful.
I will try the update directly when it is released 😊
Hey @mrnidalla. Thanks for the suggestion!
My upcoming update that enables head support from issue #6 will properly display the glint of items in shulkers again, however it still treats enchanted and non-enchanted items as the same (so a box mixed with both enchanted and non-enchanted chestplates will still show the icon of the first item when the "unique" display option is selected).
The reason I'm currently not distinguishing between them is simply because I figured it would be more useful to have all of one item grouped (e.g. diamond chestplate or enchanted diamond chestplate treated the same). I may add a config for grouping enchanted items since you believe it will be useful.
If this feature is enabled and you select the "unique" display option, then it will only show the item if all diamond chestplates are enchanted, or all diamond chestplates inside are unenchanted. However, it won't distinguish between the enchantments themselves - i.e. all enchanted diamond chestplates will be treated as one, no matter their enchantment.
This won't impact enchanted books because they are already a separate item from a normal book, so I believe the current version should already show that glint and treat books / enchanted books separately.
Hope that makes sense?