SnowyLeavesPlus

SnowyLeavesPlus

3k Downloads

Incorrect colouring of cherry leaves

ColonelGerdauf opened this issue Β· 8 comments

commented

With this kind of mod applied, the cherry trees are gradients of green, instead of the magenta-to-white as it should have been.

commented

I should specify that this is when experimental features are enabled on 1.19.4. Normal use is unaffected as cherry does not exist yet. However, people may choose to turn on the experimental features, which is part of the value of this mini-release.

commented

Still an issue on 1.20 release

commented

https://bugs.mojang.com/browse/MC-263720

As a case example. If it is the matter of cherry/azalea lacking foliage colour or colourmap, then I would suggest hard-coding values as a placeholder.

commented

Yeah this issue is annoying, will keep an eye on the mod incase it’s fixed in the future, hopefully

commented

I have an alternative solution to propose; if HSL is used, for every one point is increased in lightness, two points are reduced in saturation.

That is a straight path from whatever the original colour is to whiteish grey, with subtle differences being visible.
So the base colourmap would not be needed; at the cost of a bit of compute and memory for recalculating textures where needed. Also, it makes the mod compatible with any mod that has trees, so long as the leaves are properly mapped.

commented

Interesting! I'll definitely experiment with using resource pack shaders instead of colour providers.

commented

This is still an issue on 1.20.4!

commented

Unfortunately it seems that cherry leaves are coloured differently. They don't have biome-specific palettes and their texture isn't made to be tinted like how the other blocks are. I've essentially disabled the mod for cherry leaves so they have the vanilla look.