Sodium

Sodium

Mods
35M Downloads

firework particles (and probably particles in general) are not made above the maximum height of the world

Lolothepro opened this issue ยท 1 comments

commented

Version information

Sodium alpha 6 - 1.18.1

Expected Behavior

We should see the particles

Actual Behavior

The particles are not rendered

Reproduction Steps

Video:

output.compress-video-online.com.5.mp4

Java version

Java 17

CPU

Ryzen 1600

GPU

GTX 1070

Additional information

No response

commented

It looks like this behavior is caused by Sodium's particle culling.

sodium-fabric/src/main/java/me/jellysquid/mods/sodium/mixin/features/particle/cull/MixinParticleManager.java

Lines 60 to 69 in d50338a

for (Particle particle : queue) {
Box box = particle.getBoundingBox();
// Hack: Grow the particle's bounding box in order to work around mis-behaved particles
if (!renderer.isBoxVisible(box.minX - 1.0D, box.minY - 1.0D, box.minZ - 1.0D, box.maxX + 1.0D, box.maxY + 1.0D, box.maxZ + 1.0D)) {
continue;
}
filtered.add(particle);
}

To perform particle culling, Sodium skips rendering any particles that are not in a visible chunk section. However, particles above or below the world height are never in a visible chunk section, causing them to always be culled.

A fix similar to 885222a would likely resolve this issue.