Sodium

Sodium

35M Downloads

[Feature Request] Item Rendering Optimization

Julienraptor01 opened this issue ยท 8 comments

commented

Version information

mc1.18.1-0.4.0-alpha5+build.9

Expected Behavior

Not a such fps drop.

Actual Behavior

Fps drop

Reproduction Steps

Put yourself somewhere and let your fps stabilize and remember it.
Then open your inventory and disable REI.
Then activate REI.
And finally search for "potion".

Java version

Java 17 (the default version from the vanilla launcher)

CPU

Intel Core i7-9750H

GPU

Nvidia RTX 2060

Additional information

shedaniel/RoughlyEnoughItems#712
I did the report because https://github.com/shedaniel told me to.

commented

Likely because of enchantment glint. I'm quite sure somethings not right with the enchantment glint. Not sure.

commented

It's not only the enchant glint. You can see it by comparing the screenshots. The 2 problems are item rendering that affect everything and the enchant glint which add another layer of lag.

commented

This is not a bug, but a request for a new optimization.

The mod "immediately fast" may provide some relief for that kind of performance issues.

commented

This is not a bug, but a request for a new optimization.

The mod "immediately fast" may provide some relief for that kind of performance issues.

it was indeed a feature request, it was indeed unclear
the point is vanilla item rendering is not very good (at least judging from the results) since as soon as you start rendering items in inventories, the frame rate drops
like in vanilla just opening a double chest full of items especially if they have special effects like the enchant glint fps just fall down
and mods that add more items on the screen just make the problem worse

testing was done with default minecraft settings and with pc as optimized as possible so everything else than minecraft closed if possible
sodium version : mc1.20.2-0.5.3
mc version : 1.20.2

vanilla
444FPS while in world looking at the chest
image
432FPS while in empty chest GUI
image
266FPS when inventory filled with sticks
image
175FPS when inventory filled with debug sticks
image

same tests with sodium
430FPS while in world looking at the chest
image
422FPS while in empty chest GUI
image
303FPS when inventory filled with sticks
image
240FPS when inventory filled with debug sticks
image

as you can see, the frame rate isn't as bad as in vanilla but there's still a quite dip in performance when rendering items

commented

here are tests with ImmediatlyFast and ModernFix since they were suggested
IF version : 1.2.6+1.20.2
ModernFix version : 5.9.1+mc1.20.2

same tests with sodium + immediatlyfast
440FPS while in world looking at the chest
image
424FPS while in empty chest GUI
image
302FPS when inventory filled with sticks
image
261FPS when inventory filled with debug sticks
image

same tests with sodium + immediatlyfast + modernfix
441FPS while in world looking at the chest
image
426FPS while in empty chest GUI
image
304FPS when inventory filled with sticks
image
260FPS when inventory filled with debug sticks
image

Edit : I tested all mods with default settings, but ModernFix enhancement is disabled by default

commented

same test as up but with faster item enabled in modernfix
350FPS when inventory filled with sticks
image
286FPS when inventory filled with debug sticks
I also noticed frequent FPS lag spikes with this option it seems it has been a one time thing i can't reproduce
image

commented

Why not just use immediately fast then?

commented

Why not just use immediately fast then?

You need to remember that I'm on a powerful computer
I used to play on a less good computer that would barely hold 60fps in world and would drop to 20fps or less in full inventories and would become unplayable if i had mods that added more items to render like xEI mods

Tho the combination of the currently optional ModernFix optimization and the new currently developed screen batching in ImmediatelyFast seems to actually help to heavily reduce the problem so I'm looking forward to them