Sodium

Sodium

44M Downloads

Powder snow face culling may be excessive

muzikbike opened this issue · 1 comments

commented

Version information

sodium-fabric-mc1.17.1-0.3.4+build.13

Expected Behavior

Only the outer faces of powder snow would be culled by solid blocks - the inner faces would not be, and would only be able to be culled by other powder snow blocks.

Actual Behavior

The inner faces of powder snow are still culled against solid block faces, which goes against expected and vanilla behaviour.

Reproduction Steps

  1. Obtain powder snow
  2. Place the powder snow such that it contacts a solid block face, and that this solid block face is visible from inside the powder snow
  3. Enter the powder snow

Java version

16.0.2 64-bit

CPU

4× Intel® Core™ i3-3240 CPU @ 3.40GHz

GPU

Intel® HD Graphics 2500

Additional information

This results from the fix to #859, and has advantages and disadvantages; it gets rid of some Z-fighting issues, however this new behaviour differs substantially from vanilla in a way I'm not sure is desirable.
2022-02-03_11 24 48

One important thing to note is that it ends up exposing the non-tinted snowy grass block top, which should never be visible in normal survival:
2022-02-03_11 25 17

commented

Resolved with c937156.