Sodium

Sodium

35M Downloads

Fix fluids not having bottom texture planes on the inside

muzikbike opened this issue · 12 comments

commented

Version information

sodium-fabric-mc1.18.2-0.4.1+build.15

Expected Behavior

Since the other five faces exist, the bottom should as well.

Actual Behavior

It does not under any circumstances.

Reproduction Steps

  1. Place water above a pressure plate, with the water surrounded by four top slabs for easy access
  2. Enter the water

Java version

17.0.2 64bit

CPU

4× Intel® Core™ i3-3240 CPU @ 3.40GHz

GPU

Intel® HD Graphics 2500

Additional information

Vanilla bug https://bugs.mojang.com/browse/MC-190053, which has persisted since 1.7. Versions prior to 1.7 did not have this bug.

This has been split from #91 due to changes made to fluid rendering in 1.18.2.
2022-03-05_00 40 20

commented

Why isn't the bottom face culled against solid blocks in the screenshots? The face should only be rendered if there's no full block below (check vanilla 1.6.4 for the expected behaviour).

commented

ignore me, I just completely misunderstood what this was saying.

commented

No, you were almost right: the interior bottom face should only cull against opaque blocks. It should render as it did if there's air, glass or some other non-opaque block below.

Screenshot from 1.6.4, displaying expected behaviour (bottom face is visible against glass, but not against stone):
2024-05-05_20 22 54

Screenshot from 1.7.9, displaying current undesirable behaviour (bottom face is never visible):
2024-05-05_20 23 56

commented

0.4.10 looks like Vanilla (i.e., it is missing the bottom texture). This is a vanilla issue and a request for enhancement, not a bug.

commented

I fail to see how this is fixed in the latest version of Sodium for 1.20?
2023-06-19_09 58 07

commented

You're right, I closed this thinking it was related to the water overlay texture bug.

commented

Hello. Not sure if it is a spam. But I still have gaps at still water (any degree) on 1.19.2 + sodium 0.4.4+build.18.
The last case I met was #1473652041 (year ago).
I can't reply in #38 since it was blocked.

commented

This is not the same as #38. If you are experiencing #38, you don't need to add reports of it since it's known that it exists (and will continue to until it is deliberately fixed).

commented

This is not the same as #38.

Oh, looks like it's a bit different. Should I post a new issue then?

commented

If you are experiencing #1489 no further action is needed since it's the same as #38. If you are experiencing this issue (missing bottoms of water) also nothing needs to be done since it's a vanilla issue (and this issue already exists). If you are experiencing something that we don't already have an open issue on, you can make a new issue.

commented

I think I'm seeing chunk borders under the ice which is mentioned in #659070443. This issue only happens when sodium installed on any version after 1.18.2. I don't think it's connected to vanilla.

commented

Then you are seeing an instance of #38. You don't need to make a bug report about this since it's well-known.