Sodium

Sodium

35M Downloads

Fix water in waterlogged blocks not appearing "flat" when expected

muzikbike opened this issue · 2 comments

commented

Version information

sodium-fabric-mc1.18.2-0.4.1+build.15

Expected Behavior

The surface of the water should appear completely straight, much like it does in this geometrically equivalent slab arrangement:
2022-03-05_00 55 26
2022-03-05_00 55 29

Or like it does when the arrangement is surrounded by full blocks:
2022-03-05_00 53 33
2022-03-05_00 53 36

Actual Behavior

The water level does not appear even, instead bulging in the center.
2022-03-05_00 52 29
2022-03-05_00 52 31
2022-03-05_00 52 45
2022-03-05_00 52 50

Reproduction Steps

  1. Create an arrangement of four stairs as to create an "offset slab"
  2. Waterlog these four stair blocks
  3. Stare at the water

Java version

17.0.2 64bit

CPU

4× Intel® Core™ i3-3240 CPU @ 3.40GHz

GPU

Intel® HD Graphics 2500

Additional information

Vanilla bug https://bugs.mojang.com/browse/MC-127270. It seems that 1.18.2 made this effect less intense, but it's still there.

This seems to arise because the water doesn't have any full blocks outside of it for it to appear at a higher level, despite it being contained by solid blocks in its own space.

commented

(Split from #91 due to 1.18.2's changes)

commented

Unlike #1212, which is wrong, this report is a valid request for a visual enhancement compared to Vanilla (which looks exactly the same as Sodium): in this instance, the water looks tilted, but is actually not flowing.