Sodium

Sodium

35M Downloads

Fix vanilla precision issues in block models

muzikbike opened this issue · 2 comments

commented

Version information

sodium-fabric-mc1.18.2-0.4.1+build.15

Expected Behavior

All pixel sizes should be consistent and pixels and their borders should align perfectly.

Actual Behavior

In a few select cases, there appear to be precision loss issues in model handling which result in ever so slightly incorrect sizes for pixels, model elements and so on. Examples are given below.

Reproduction Steps

Doors (MC-169897):

  • Place a door
  • Position yourself at the hinge portion (the region that stays constant when the door is closed and open)
  • Open and close the door and observe closely

Cauldrons, hoppers and composters (MC-246224):

  • Place any or all of these three blocks
  • Look very closely at all of the top corners

Farmland, dirt paths (MC-252256):

  • Position farmland or a dirt path next to a full block
  • Try to see the second row of pixels from the top on the full block beside it

Java version

17.0.2 64bit

CPU

4× Intel® Core™ i3-3240 CPU @ 3.40GHz

GPU

Intel® HD Graphics 2500

Additional information

Door (hard to tell from screenshots, so I recommend reproducing this in game):
2022-05-27_15 51 29
2022-05-27_15 51 30

Cauldron, hopper, composter:
2022-05-27_15 52 19
2022-05-27_15 52 23

Dirt path, farmland:
2022-05-27_15 52 49

These effects can likely be found in far more circumstances.

commented

This should be fixed with ea01727.

commented

https://github.com/MehVahdJukaar/modelfix-multi fixes this issue from my testing with affected custom models. I don't know if it'd be possible to integrate this same fix into Sodium somehow, assuming that's something that even gets done with the mod?