Expected Behavior

Campfires consistently produce the same amount of smoke.

Actual Behavior

Every time a campfire is reloaded, it produces more smoke. When the world is completely reloaded, the campfire again produces the appropriate amount of smoke.

Might affect other particles too, haven't tested.

Reproduction Steps

1. Place a campfire
2. Teleport into unloaded chunks
3. Teleport back
4. Repeat steps 2 and 3
   → At some point there's a lot of smoke coming from the campfire.

When breaking the campfire and placing another campfire in the same location, the issue continues to happen.

Attachments

Here's a video: https://youtu.be/boqgWAhorSM

Tested versions

The bug doesn't happen in vanilla 1.16.1, but it does happen with Sodium 0.1.0-fabric.

Also happens in 620f5a3.

I'm using fabric version 0.9.0+build.204 (latest) and Minecraft version 1.16.1.

System Information

• Java Version: 1.8.0_51 and 12.0.1
• CPU: Intel Core i7-3770 @ 3.40 GHz
• GPU: GeForce GTX 1050 Ti

I have observed this issue with campfires producing way too much smoke in Sodium before, but I'm not sure what the issue is exactly. We might be adding the same tile entitiy renderer to the global render list multiple times. Beacons might also be affected, if so.

the same thing happens with the particles of the spawners

Not sure if this is related but, I got 24,000 hoppers with composters on top of them, the game runs smoothly. But when I unload the chunks by teleporting away 1000 blocks, and returning the game is slightly laggier, if you keep repeat leaving the area and coming back the game becomes laggier and laggier, and I have to relog to fix the issue.

After placing a single campfire in an empty world and flying back and forth a bit, the client world had 3 camp fire tile entities registed.

It seems like the fix was simple, PR coming soon

Merged into stable as 5af41c1.