Sodium

Sodium

35M Downloads

Lava top face is sometimes culled when it can be visible from under the lava blocks height

GibrielS opened this issue ยท 7 comments

commented

Version information

sodium-fabric-mc1.17.1-0.3.4+build.13

Expected Behavior

The top lava face should not be invisible because it is within sight

Actual Behavior

The top lava face is invisible even though the player can see it

Reproduction Steps

*this issue has not been reproduced in a vanilla singleplayer world
Go to the same location in Hypixel as shown in the screenshots.

Java version

16.0.2

CPU

8th gen Intel core i7 (i7-8700B)

GPU

Intel UHD Graphics 630

Additional information

Culling issue

commented

your instructions are not very clear and I'm not sure what you actually mean. Do you mean the inner bottom face of the lava as seen missing in this screenshot? (Spectator mode makes it so there's no lava fog)

Screenshot 2024-05-12 at 17 50 23

commented

For this to be caused by block face culling I'm assuming the section boundary is right below the lowest lava block. It's fixable but either making those faces UNASSIGNED or not making them bend. (We might have an issue for bent fluids, though I'm not sure if this is related to those that have merit)

commented

Something weird is going on here. I can't seem to replicate the bug in a singleplayer world...

commented

cannot replicate in my single player world with litematica
2024-05-12_20 01 14

commented

My bad, I really should have provided a screenshot. Here is a pretty good setup for it. Setup may have changed slightly since originally posted, version tested: 1.20.4 with the latest 1.20.3 sodium release as of posting this. (unrelated side note: thanks for contributing to one of my favorite minecraft mods!)

2024-05-12_19 31 38

commented

In case the issue isn't obvious, here is a vanilla screenshot of the same location. (And my crosshair is conveniently on the exact mesh that is bugging in the other screenshot!)
2024-05-12_19 38 48

commented

important to note all the lava is source blocks

I also got a new PC which still suffers the same issue so it probably isn't a graphics driver bug.

the bug is that the culler assumes that the lava isn't bending downwards, when it is.