Sodium

Sodium

Mods
35M Downloads

Mixin Rule `mixin.features.fast_biome_colors` crashes unavoidably when set to `false`

alcatrazEscapee opened this issue ยท 1 comments

commented

Version information

sodium-fabric-mc1.19.3-0.4.8+build.22

Reproduction Steps

  1. Add the following line to .minecraft/config/sodium-mixins.properties
mixin.features.fast_biome_colors=false
  1. Attempt to join a world. The game will immediately crash upon attempting to render the world.

Crash Report file

Crash Report: crash-2023-01-18_12.27.40-client.txt
Full Log: latest.log

Additional information

This feature disables this MixinClientWorld, which notably implements BiomeSeedProvider on ClientWorld.

This is then used independently of the fast_biome_colors option, for instance in WorldSlice, here:

sodium-fabric/src/main/java/me/jellysquid/mods/sodium/client/world/WorldSlice.java

Line 139 in cd97d9d

this.biomeAccess = new BiomeAccess(this::getStoredBiome, ((BiomeSeedProvider) this.world).getBiomeSeed());

This should probably be moved to it's own mixin, and one that isn't disabled by mixin.features.fast_biome_colors=false. As the rest of this mixin actually pertains to the fast biome colors feature.

commented

Fixed by d10e380