Incorrect shadows
StealWonders opened this issue · 6 comments
Expected Behavior
Expected should be that the shadows either be darker than normal or just no shadows.
See this screenshot:
Actual Behavior
Sodium-fabric causes the shadows of the trees and around the house to be lighter than the actual normal lighting... This looks very unrealistic :(
Screenshot:
Reproduction Steps
Build a tree and look at its shadows, generate a vanilla world, and look at those shadows.
This issue is with vanilla generated worlds too. Depending on biome it looks worse or less.
System Information
- Java Version: 1.8.0_51 64bit
- CPU: Intel(R) Core(TM) i7-4790K
- GPU: GeForce GTX 1080
Enabled in the mod:
- Chunk Renderer: OpenGL 4.6
Sodium re-implements the entire smooth lighting engine in order to improve chunk rendering performance and to fix a few graphical issues. As a result, the rendering between the two will not always be identical.
However, it is rather difficult for me to tell the difference between these screenshots as they've been compressed heavily and the camera moves between each shot. If you're able to, cleaner images would help a lot in diagnosing this problem.
It might not be obvious as the marking is not clear but if you look near big outline just on the inner side some blocks look de-saturated/brightened
in this area:
Alot more contrast:
Edge here:
this should make it a bit clearer
Sorry for the images but the issue is hardly noticeable.
No sodium:
With sodium:
You may be able to tell that the wall of the house is outlined by a two block wide lighter grass strip.
Image highlighting the border of where the shadows are to make it more clear.
Light level near the house (using Vanilla):
Light level further away from the house (using Vanilla):
The light levels are the same when using sodium of course but the coloring of the grass (shadows) is brighter than normal grass which makes no sense...
Are you using the latest revision of Sodium? There were some issues in an earlier version with the vertex encoding stage that caused weirdness like this.
Are you using the latest revision of Sodium? There were some issues in an earlier version with the vertex encoding stage that caused weirdness like this.
Let me recompile. Here are some further screenshots of the issue for now:
