The sky is not visible in the water
Lolothepro opened this issue ยท 11 comments
Bug Description
No response
Reproduction Steps
Go into the water
The sun is not rendered
Log File
Crash Report
... so I'm suggesting this should be fixed in a better way to remove the bleeding ...
This would require re-implementing the skybox coloration function into the shaders, which while not impossible, is work that I don't want to be doing, as the original code is difficult to read through and understand. Maybe someone could volunteer to do that, but it isn't within the cards otherwise.
... so I'm suggesting this should be fixed in a better way to remove the bleeding ...
This would require re-implementing the skybox coloration function into the shaders, which while not impossible, is work that I don't want to be doing, as the original code is difficult to read through and understand. Maybe someone could volunteer to do that, but it isn't within the cards otherwise.
If that is the case, @jellysquid3 would it be better to just put a help wanted label on the issue and reopen it, so people know that they could actually contribute to this?
@Lolothepro Sodium just hiding sun moon underwater is probably not such a good fix for that bug, I suggest to please reopen this issue if this bug has not already been reported before and closed. If it has, maybe discuss on the CaffeineMC discord and see if it would be viable to fix in a better way now.
Why is hiding the sun under water not a good solution? It fixes the mojira issue by making sure the sun is hidden by the water fog.
Why is hiding the sun under water not a good solution? It fixes the mojira issue by making sure the sun is hidden by the water fog.
@douira Because it is a vanilla parity enhancement to not just hide it, so I'm suggesting this should be fixed in a better way to remove the bleeding instead of removing the sun and moon.
So this is why I'm suggesting @Lolothepro to open this issue
Looks like a duplicate of wontfix issue #2485
Looks like a duplicate of wontfix issue #2485
I'd suggest maybe @jellysquid3 decide on this issue in this case
