Incompatibility with Emotecraft
Lolip-p opened this issue · 5 comments
Bug Description
Using the Emotecraft mod 2.2.5 and Sodium 0.5.6+ or 0.5.8 the following happens: the bones in the elbows and knees disappear. Animations stop looking beautiful. The animation used is the same. This error occurs starting from version 0.5.6. It is also present in the newest version at the moment, 0.5.8.
Emotecraft : https://github.com/KosmX/emotes/releases/tag/2.2.5
It will be more clear to look at the screenshots:
0.5.3
0.5.6+ or 0.5.8
Reproduction Steps
- Minecraft version 1.20.1 Quilt or Fabric.
- Launch Sodium 0.5.3 and Emotecraft 2.2.5. Select an animation where there are bends in the joints. We see that everything is fine.
- Launch Sodium 0.5.6+ or 0.5.8 and Emotecraft 2.2.5. We select the same animation, we see that it is broken.
Log File
Crash Report
The mod author can set a mixin rule to disable features.render.entity, but this won't work with Iris, and it will reduce performance in the general case.
Not really sure why this mod is broken. Sodium should just be rendering what it's asked to. Needs investigation.
Not really sure why this mod is broken
EmoteCraft replaces the quads in cuboids with its own when playing the bending animation, which is not possible while sodium completely replaces cuboids
But they have a second way where they just replace the Cuboid render with their own, which also doesn't work with sodium because sodium overrides the vanilla renderer calls.
This all works by redirecting the render in ModelPart, which is exactly what was overridden by sodium
Hmmm... we'll have to figure out some kind of interface they can use then. I don't see a way to avoid a conflict here otherwise. Suggestions welcome.
I'm very busy (and will be for some time), but I can make a compatibility mode (make my mod use sodium if sodium is loaded, or behave normal otherwise)
I don't (yet) know how can I change sodium to render differently..