Sodium

Sodium

35M Downloads

Possible regression of potted cactus/bamboo/azalea fix

muzikbike opened this issue ยท 2 comments

commented

Bug Description

#858 was fixed not too long ago, allowing for the top faces of these four blocks to be culled as expected. However, that fix no longer seems to work, and we have reverted back to the undesirable vanilla behaviour.

2024-05-02_18 52 47

Reproduction Steps

  1. Place a cactus, azalea or bamboo in a flower pot
  2. Place a full opaque block above the pot
  3. Enter that block in Spectator mode

Log File

crash-2024-05-02_18.58.46-client.txt

Crash Report

latest.log

commented

For some context: this was reverted intentionally in c937156, because the original fix is too strict and breaks some modded/resource pack models, as well as altering powder snow rendering, while not really reducing the amount of vertices being rendered very much.

commented

Yes. This change was reverted, as it is produces too many issues for a very negligible gain (essentially none in any real-world scene.) It will not be re-implemented.