Sodium

Sodium

44M Downloads

Uncaught exceptions thrown while probing for graphics adapters should not be allowed to crash the game

jellysquid3 opened this issue ยท 2 comments

commented

We've seen a few crashes at startup that are caused by exceptions getting thrown while enumerating graphics adapters. This is really less than ideal, because there is going to always be weird stuff we can't accommodate, so we should catch these exceptions and allow for the enumeration to fail gracefully.

When enumerating graphics adapters fails, there should also be a clear warning in the log file which indicates the exception, so that we can find these issues in the wild and fix them where possible. It should also suggest that users open a bug report with information about their hardware and driver versions.

commented

An example of this problem can be seen with issues #2545 and #2550. While they are both valid bug reports that need to be fixed, they unnecessarily crashed the game.

commented

Fixed in 7c53462.