Bug Description

3d4cf6a

I suspect that this commit causes undesirable side effects with waterlogged double slabs.

Sodium:

Vanilla:

‎
‎
‎
It causes Z-Fighting with Sodium
i.e:

Reproduction Steps

Make a wall of waterlogged double slabs
Switch to spectator mode
Go into the wall or move away from the wall

Log File

https://mclo.gs/wS0lUP4

Crash Report

Vanilla's rendition of this scene is objectively worse.

Vanilla's rendition of this scene is objectively worse.

Yes, but it causes Z-Fighting

There's Z-fighting in both images

There's Z-fighting in both images

Both images are with Sodium

Oh I see

presumed root cause is bc38d56 : that code changed the test on isFaceSturdy on the pos, dir to the adjPos, dir.getOpposite(). It makes sense for the case when the water is occluded by a neighbor block, but that removed the test for water being occluded by the faces of the waterlogged block itself.

This also causes z-fighting on full-faces of waterlogged stairs.