Block models causing a saturation problem on blocks.
Borous opened this issue ยท 5 comments
Bug Description
With the latest version of Sodium, sodium-fabric-0.6.0-beta.2+mc1.21.1, there occurs a strange issue wherein when using a resource pack to add models to a block --such as bushy leaves from vanilla tweaks-- it amps up the saturation of the block significantly. Difference can be seen below:
Reproduction Steps
To reproduce this issue; Use sodium-fabric-0.6.0-beta.2+mc1.21.1, then load any resourcepack making use of block models on seemingly transparent blocks.
VanillaTweaks_r434121_MC1.21.x.zip
Log File
No Such File available.
Crash Report
No Such File available.
It is taken at more or less the exact time of day, I noticed the difference immediately after updating to the aforementioned version of Sodium
The brightness in both screenshots doesn't appear to be the same, as seen in other blocks (especially the stone.) Are you sure that both screenshots were taken at the same time of day and brightness level?
Sodium also uses a better energy-conserving function in texture processing, which makes a difference. In Minecraft (the leftmost screenshot) you can see that the extra geometry is a different brightness from the leaf block itself, where as in Sodium they are consistent.
From my own testings, the color with Sodium+Bushy-leaves is close to the color without bushy-leaves. Do you also see a deviation in color between vanilla+bushy and pure vanilla?
Some difference is to be expected since we use an alternative approach to generating mip-maps (which is higher quality and preserves brightness.) We don't intend to change this behavior, since doing so would regress many other textures.
If you do not like this behavior, you can modify the textures within the resource pack so that transparent pixels have a (darker) color value assigned, and instead are very slightly opaque (alpha of <10). That will bias the generation of mip-maps to have darker colors like you expect.