Seams in complex block models more noticeable in 0.6.0 Beta 4
arrtisan opened this issue ยท 2 comments
Bug Description
Was playing multiplayer with 0.6.0 Beta 4 in 1.21.3 and noticed that some stairs were 'sparkling'. After some testing in a singleplayer world, it seems like stairs have more noticeable seams than usual, with little holes appearing and disappearing rapidly. This effect is the strongest when the player and/or the camera is moving, and when there is light behind the stairs. The stairs being a dark color or in darkness also make the effect more noticeable. This most prominently affects stairs, but also other blocks with complex models like hoppers, item frames, pots, etc.. Below I have linked videos from a small testing world I made.
Sodium 0.6.0 Bug Report Videos
(If watching in Google Drive, make sure to set the video quality to the highest)
The videos were recorded in 1.21.3. One was recorded in vanilla, and the other two with Fabric API 0.107.0 and either Sodium 0.6.0 Beta 3 or Beta 4. Please also note that I have a monitor with large, visible pixels, which could be making this effect more apparent for me.
In vanilla, these holes appear along the seams in stairs in small numbers. These holes also appear in the corners of full blocks (you can briefly see one as I look up to the dirt ceiling above me). They also appear on the legs of cauldrons, on the inside corners of pots, and on the back of item frames, and I would guess in other block models, although I didn't notice any on anvils, turtle eggs, or hoppers. Overall, these holes aren't very noticeable in vanilla-- I had never really noticed them on blocks myself.
In Sodium 0.6.0 Beta 3, the behavior is largely the same, except I no longer see any holes in the corners of full blocks.
In Sodium 0.6.0 Beta 4, these holes appear more commonly on stairs, creating a 'sparkling' effect. I would guess stairs are split into fourths when it comes to their models, since the seams are noticeable on the edges of the 4 squares of its side face. Also, when there is a full block in front of the stair, the seam between the full block and the stair has the same holes (the recording butchered it though). You can also see at the end of the clip that these holes are noticeable in some stairs even when not in a lower light level. The cauldron, anvil, and turtle eggs all seem to have the same behavior as vanilla and Beta 3, but in this version: Hoppers now have noticeable seams, especially on the top face of the block model. Pots, which previously just had one hole in each inside corner, now have a lot more. Item frames previously had some seams on the back, but in Beta 4 those are now more noticeable, with some appearing on the front side of the model.
Even though this change is likely helping performance (my uneducated guess is that this is a result of Pull Request #2508) and the effect isn't that apparent and can only be seen in rare cases, I still thought a bug report was warranted given that these seams are more noticeable than they are in vanilla and in previous versions of Sodium.
Reproduction Steps
This effect is most obvious when the blocks are in front of something bright, and are darkly colored or are in darkness themselves. I first noticed this effect with quartz stairs that were slightly in a shadow and in front of the sky. Similar to what I did in my testing world, you can replicate this on a wide scale by doing the following:
- Generate any world and build up into the sky about 30 blocks
- Turn your render distance all the way down so that you can mostly only see the skybox
- Turn off the weather and daylight cycles during daylight for more convenient testing
- Build walls of varying stairs, item frames, cauldrons, hoppers, pots, and other blocks with complex models, focusing on the ones changed in #2508 (/tick freeze is helpful for testing item frames)
- Build or use /fill to create a platform above these blocks so that they are shrouded in darkness
- Can also build walls of any of these blocks in regular daylight to still see the effect, although less prominently
- Move the camera and/or the player slowly while looking at the blocks at different angles to see the effect
- Swap between vanilla, Beta 3, and Beta 4 to observe the differences in behavior
Again, please note that I have a monitor with large, visible pixels, which could be making this effect more apparent for me.
