Expected Behavior

Block textures should be rendered seamlessly.

Actual Behavior

Certain non-vanilla texture packs (e.g., VanillaBDCraft, PureBDCraft) have odd edge rendering in the east-west direction. It looks like the texture isn't quite rendered all the way to the edge of the block.

Reproduction Steps

1. Checkout the latest code on 1.16.x/dev (this is f577eb2 at the time).
2. Run ./gradlew runClient to get a client running.
3. Add the 1.16.1 PureBDCraft resource pack and apply it.
4. Create/load a superflat world.
5. Look at the ground blocks.

Attachments

This is what my world looked like with the PureBDCraft textures:
Notice the artifacts at the edge of the blocks heading in the east-west direction.

On a hunch, I reverted the change in #122 and loaded the world back up. Here it looks normal:

It's worth noting that I've never found an issue with the BDCraft texture packs in other installations, just with the latest sodium. It's also interesting that the vanilla textures render just fine.

System Information

• Java Version: 1.8.0_265 64 bit
• CPU: 6x Intel(R) Core(TM) i5-9400 CPU @ 2.90 GHz
• GPU: GeForce GTX 1050/PCIe/SSE2 4.6.0 NVIDIA 440.100

After commit 547c41c, this issue is mostly fixed. You can still reproduce it by getting a resource pack that adds more 3D models though. For example, there are still white dots rendering on the edges of doors if you get Vanilla Tweak's 3D doors and trapdoors pack, whereas they don't render the dots with the option turned off.
Video demonstrating the issue: https://www.youtube.com/watch?v=p3udEdvZ_cM

The 3d door models from VT have the issue w/o sodium as well. It appears to be a problem with VT itself.

Issue appears fixed by MrMangoHands patch in my testings with Sphax 256px on AMD Rx580 (CVF on, MultiDraw 4.3)

Still present in 0.1.1-1.16.4 SNAPSHOT;

There is also a thin red outline around transparent block textures (like flowers that are made of two flat textures in a cross).

As said above, what appears to cause the issue is using high-res texture pack (256px). Looks like a rounding error.

Following a comment from JellySquid:

does it go away if you disable Video Settings > Advanced > Use Compact Vertex Format?

Yes, yes it does.

Issue is completely fixed in sodium/next