NeoForge's API is not used in `ModelBlockRenderer#renderModel` mixin
SuperMartijn642 opened this issue ยท 0 comments
Bug Description
NeoForge adds an overload to ModelBlockRenderer#renderModel with extra parameters for level, position, and block state. These extra parameters are then used when querying block model parts from NeoForge's BlockStateModelExtension#collectParts API.
Sodium mixes into and intercepts the ModelBlockRenderer#renderModel overload from NeoForge in ModelBlockRendererMixin.
The mixin from Sodium ignores the additional level, position, and block state arguments and calls the vanilla BlockStateModel#collectParts method instead of NeoForge API.
Reproduction Steps
Create a BlockStateModel which overwrites BlockStateModelExtension#collectParts.
Call NeoForge's overload of ModelBlockRenderer#renderModel with level, position, and block state arguments for the created model.
Observe that the model receives null for the level, position, and block state arguments.